mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Capture the rationale for -Zallow-features= in bootstrap.py

Browse Source
This commit is contained in:
David Tolnay 2024-01-20 09:47:53 -08:00
parent 6745c6000a
commit f6b3bcc431
No known key found for this signature in database
GPG Key ID: F9BA143B95FF6D82
1 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/bootstrap/bootstrap.py
View File

@ -924,17 +924,29 @@ class RustBuild(object):
# default toolchain is not nightly. # default toolchain is not nightly.
# #
# But that setting has the collateral effect of rust-analyzer also # But that setting has the collateral effect of rust-analyzer also
# passing RUSTC_BOOTSTRAP=1 to all x.py invocations too (the various overrideCommand). # passing RUSTC_BOOTSTRAP=1 to all x.py invocations too (the various
# For compiling bootstrap that can cause spurious rebuilding of bootstrap when # overrideCommand).
# rust-analyzer x.py invocations are interleaved with handwritten ones on the
# command line.
# #
# Set RUSTC_BOOTSTRAP=1 consistently. # Set a consistent RUSTC_BOOTSTRAP=1 here to prevent spurious rebuilds
# of bootstrap when rust-analyzer x.py invocations are interleaved with
# handwritten ones on the command line.
env["RUSTC_BOOTSTRAP"] = "1" env["RUSTC_BOOTSTRAP"] = "1"
default_rustflags = "" if env.get("RUSTFLAGS_BOOTSTRAP", "") else "-Zallow-features=" # If any of RUSTFLAGS or RUSTFLAGS_BOOTSTRAP are present and nonempty,
# we allow arbitrary compiler flags in there, including unstable ones
env.setdefault("RUSTFLAGS", default_rustflags) # such as `-Zthreads=8`.
#
# But if there aren't custom flags being passed to bootstrap, then we
# cancel the RUSTC_BOOTSTRAP=1 from above by passing `-Zallow-features=`
# to ensure unstable language or library features do not accidentally
# get introduced into bootstrap over time. Distros rely on being able to
# compile bootstrap with a variety of their toolchains, not necessarily
# the same as Rust's CI uses.
if env.get("RUSTFLAGS", "") or env.get("RUSTFLAGS_BOOTSTRAP", ""):
# Preserve existing RUSTFLAGS.
env.setdefault("RUSTFLAGS", "")
else:
env["RUSTFLAGS"] = "-Zallow-features="
target_features = [] target_features = []
if self.get_toml("crt-static", build_section) == "true": if self.get_toml("crt-static", build_section) == "true":