mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove bar from blacklisted names

Browse Source
This commit is contained in:
Iain Brandram-Adams 2020-06-14 01:24:36 +12:00
parent 742706511c
commit f663a21c8f
2 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clippy_lints/src/utils/conf.rs
View File

@ -107,7 +107,7 @@ macro_rules! define_Conf {
pub use self::helpers::Conf; pub use self::helpers::Conf;
define_Conf! { define_Conf! {
/// Lint: BLACKLISTED_NAME. The list of blacklisted names to lint about /// Lint: BLACKLISTED_NAME. The list of blacklisted names to lint about
(blacklisted_names, "blacklisted_names": Vec<String>, ["foo", "bar", "baz", "quux"].iter().map(ToString::to_string).collect()), (blacklisted_names, "blacklisted_names": Vec<String>, ["foo", "baz", "quux"].iter().map(ToString::to_string).collect()),
/// Lint: COGNITIVE_COMPLEXITY. The maximum cognitive complexity a function can have /// Lint: COGNITIVE_COMPLEXITY. The maximum cognitive complexity a function can have
(cognitive_complexity_threshold, "cognitive_complexity_threshold": u64, 25), (cognitive_complexity_threshold, "cognitive_complexity_threshold": u64, 25),
/// DEPRECATED LINT: CYCLOMATIC_COMPLEXITY. Use the Cognitive Complexity lint instead. /// DEPRECATED LINT: CYCLOMATIC_COMPLEXITY. Use the Cognitive Complexity lint instead.

23
tests/ui/blacklisted_name.rs
View File

@ -12,29 +12,32 @@ fn test(foo: ()) {}
fn main() { fn main() {
let foo = 42; let foo = 42;
let bar = 42;
let baz = 42; let baz = 42;
let quux = 42;
// Unlike these others, `bar` is considered an acceptable name to use.
// See https://github.com/rust-lang/rust-clippy/issues/5225.
let barb = 42; let food = 42;
let barbaric = 42; let foodstuffs = 42;
let bazaar = 42;
match (42, Some(1337), Some(0)) { match (42, Some(1337), Some(0)) {
(foo, Some(bar), baz @ Some(_)) => (), (foo, Some(baz), quux @ Some(_)) => (),
_ => (), _ => (),
} }
} }
fn issue_1647(mut foo: u8) { fn issue_1647(mut foo: u8) {
let mut bar = 0; let mut baz = 0;
if let Some(mut baz) = Some(42) {} if let Some(mut quux) = Some(42) {}
} }
fn issue_1647_ref() { fn issue_1647_ref() {
let ref bar = 0; let ref baz = 0;
if let Some(ref baz) = Some(42) {} if let Some(ref quux) = Some(42) {}
} }
fn issue_1647_ref_mut() { fn issue_1647_ref_mut() {
let ref mut bar = 0; let ref mut baz = 0;
if let Some(ref mut baz) = Some(42) {} if let Some(ref mut quux) = Some(42) {}
} }