mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #114539 - Enselic:unneeded-fixme, r=ehuss

Browse Source 
linkchecker: Remove unneeded FIXME about intra-doc links

It was added by https://github.com/rust-lang/rust/pull/77971 but the adder [proposed](https://github.com/rust-lang/rust/pull/77971#issuecomment-710026798) that the added code is a good fallback to have in case rustdoc gets buggy, and I agree. So remove the FIXME.

This PR is part of #44366 which is E-help-wanted.

r? `@jyn514` since you added the FIXME

`@rustbot` label T-dev-tools
This commit is contained in:
Matthias Krüger 2023-08-06 17:26:31 +02:00 committed by GitHub
commit f542163351
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/tools/linkchecker/main.rs
View File

@ -368,7 +368,6 @@ impl Checker {
return; return;
} }
// Search for intra-doc links that rustdoc didn't warn about // Search for intra-doc links that rustdoc didn't warn about
// FIXME(#77199, 77200) Rustdoc should just warn about these directly.
// NOTE: only looks at one line at a time; in practice this should find most links // NOTE: only looks at one line at a time; in practice this should find most links
for (i, line) in source.lines().enumerate() { for (i, line) in source.lines().enumerate() {
for broken_link in BROKEN_INTRA_DOC_LINK.captures_iter(line) { for broken_link in BROKEN_INTRA_DOC_LINK.captures_iter(line) {