mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #103938 - notriddle:notriddle/search-results-border-bottom, r=GuillaumeGomez

Browse Source 
rustdoc: clean up hardcoded CSS border color on search results

Hardcoded colors in rustdoc.css should usually be avoided.

Preview: http://notriddle.com/notriddle-rustdoc-demos/border-bottom-search/test_dingus/?search=test
This commit is contained in:
Matthias Krüger 2022-11-04 06:40:34 +01:00 committed by GitHub
commit f35dccbc72
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/librustdoc/html/static/css/rustdoc.css
View File

@ -894,7 +894,7 @@ so that we can apply CSS-filters to change the arrow color in themes */
/* A little margin ensures the browser's outlining of focused links has room to display. */ /* A little margin ensures the browser's outlining of focused links has room to display. */
margin-left: 2px; margin-left: 2px;
margin-right: 2px; margin-right: 2px;
border-bottom: 1px solid #aaa3; border-bottom: 1px solid var(--border-color);
} }
.search-results > a > div { .search-results > a > div {
@ -1874,7 +1874,6 @@ in storage.js
/* Display an alternating layout on tablets and phones */ /* Display an alternating layout on tablets and phones */
.search-results > a { .search-results > a {
border-bottom: 1px solid #aaa9;
padding: 5px 0px; padding: 5px 0px;
} }
.search-results .result-name, .search-results div.desc { .search-results .result-name, .search-results div.desc {

18
src/test/rustdoc-gui/search-result-color.goml
View File

@ -75,6 +75,12 @@ assert-css: (
{"color": "rgb(0, 150, 207)"}, {"color": "rgb(0, 150, 207)"},
) )
// Checking the color of the bottom border.
assert-css: (
".search-results > a",
{"border-bottom-color": "rgb(92, 103, 115)"}
)
// Checking the color of "keyword" text. // Checking the color of "keyword" text.
assert-css: ( assert-css: (
"//*[@class='result-name']//*[text()='(keyword)']", "//*[@class='result-name']//*[text()='(keyword)']",
@ -181,6 +187,12 @@ assert-css: (
{"color": "rgb(221, 221, 221)"}, {"color": "rgb(221, 221, 221)"},
) )
// Checking the color of the bottom border.
assert-css: (
".search-results > a",
{"border-bottom-color": "rgb(224, 224, 224)"}
)
// Checking the color for "keyword" text. // Checking the color for "keyword" text.
assert-css: ( assert-css: (
"//*[@class='result-name']//*[text()='(keyword)']", "//*[@class='result-name']//*[text()='(keyword)']",
@ -272,6 +284,12 @@ assert-css: (
{"color": "rgb(0, 0, 0)"}, {"color": "rgb(0, 0, 0)"},
) )
// Checking the color of the bottom border.
assert-css: (
".search-results > a",
{"border-bottom-color": "rgb(224, 224, 224)"}
)
// Checking the color for "keyword" text. // Checking the color for "keyword" text.
assert-css: ( assert-css: (
"//*[@class='result-name']//*[text()='(keyword)']", "//*[@class='result-name']//*[text()='(keyword)']",