mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename the FIXMEs, remove a few that dont matter anymore

Browse Source
This commit is contained in:
Michael Goulet 2024-11-01 18:49:08 +00:00
parent c2db7fa360
commit f0cf9969cb
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clippy_utils/src/qualify_min_const_fn.rs
View File

@ -404,7 +404,7 @@ fn is_stable_const_fn(tcx: TyCtxt<'_>, def_id: DefId, msrv: &Msrv) -> bool {
} }
fn is_ty_const_destruct<'tcx>(tcx: TyCtxt<'tcx>, ty: Ty<'tcx>, body: &Body<'tcx>) -> bool { fn is_ty_const_destruct<'tcx>(tcx: TyCtxt<'tcx>, ty: Ty<'tcx>, body: &Body<'tcx>) -> bool {
// FIXME(effects, fee1-dead) revert to const destruct once it works again // FIXME(const_trait_impl, fee1-dead) revert to const destruct once it works again
#[expect(unused)] #[expect(unused)]
fn is_ty_const_destruct_unused<'tcx>(tcx: TyCtxt<'tcx>, ty: Ty<'tcx>, body: &Body<'tcx>) -> bool { fn is_ty_const_destruct_unused<'tcx>(tcx: TyCtxt<'tcx>, ty: Ty<'tcx>, body: &Body<'tcx>) -> bool {
// Avoid selecting for simple cases, such as builtin types. // Avoid selecting for simple cases, such as builtin types.
@ -412,7 +412,7 @@ fn is_ty_const_destruct_unused<'tcx>(tcx: TyCtxt<'tcx>, ty: Ty<'tcx>, body: &Bod
return true; return true;
} }
// FIXME(effects) constness // FIXME(const_trait_impl) constness
let obligation = Obligation::new( let obligation = Obligation::new(
tcx, tcx,
ObligationCause::dummy_with_span(body.span), ObligationCause::dummy_with_span(body.span),

4
tests/ui/missing_const_for_fn/could_be_const.fixed
View File

@ -104,7 +104,7 @@ fn main() {}
struct D; struct D;
/* FIXME(effects) /* FIXME(const_trait_impl)
impl const Drop for D { impl const Drop for D {
fn drop(&mut self) { fn drop(&mut self) {
todo!(); todo!();
@ -113,7 +113,7 @@ impl const Drop for D {
*/ */
// Lint this, since it can be dropped in const contexts // Lint this, since it can be dropped in const contexts
// FIXME(effects) // FIXME(const_trait_impl)
const fn d(this: D) {} const fn d(this: D) {}
//~^ ERROR: this could be a `const fn` //~^ ERROR: this could be a `const fn`

4
tests/ui/missing_const_for_fn/could_be_const.rs
View File

@ -104,7 +104,7 @@ fn main() {}
struct D; struct D;
/* FIXME(effects) /* FIXME(const_trait_impl)
impl const Drop for D { impl const Drop for D {
fn drop(&mut self) { fn drop(&mut self) {
todo!(); todo!();
@ -113,7 +113,7 @@ fn drop(&mut self) {
*/ */
// Lint this, since it can be dropped in const contexts // Lint this, since it can be dropped in const contexts
// FIXME(effects) // FIXME(const_trait_impl)
fn d(this: D) {} fn d(this: D) {}
//~^ ERROR: this could be a `const fn` //~^ ERROR: this could be a `const fn`