Shrink ra_parser::Event from 32 bytes to 16 bytes

This boxes the Error variant with the assumption that it is rarely constructed
This commit is contained in:
Simon Vandel Sillesen 2020-05-16 18:06:23 +02:00
parent ebaa05a447
commit ef6d53521f
3 changed files with 3 additions and 3 deletions

View File

@ -25,7 +25,7 @@
pub use syntax_kind::SyntaxKind;
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub struct ParseError(pub String);
pub struct ParseError(pub Box<String>);
/// `TokenSource` abstracts the source of the tokens parser operates on.
///

View File

@ -192,7 +192,7 @@ pub(crate) fn bump_remap(&mut self, kind: SyntaxKind) {
/// structured errors with spans and notes, like rustc
/// does.
pub(crate) fn error<T: Into<String>>(&mut self, message: T) {
let msg = ParseError(message.into());
let msg = ParseError(Box::new(message.into()));
self.push_event(Event::Error { msg })
}

View File

@ -70,6 +70,6 @@ pub fn finish_node(&mut self) {
}
pub fn error(&mut self, error: ra_parser::ParseError, text_pos: TextSize) {
self.errors.push(SyntaxError::new_at_offset(error.0, text_pos))
self.errors.push(SyntaxError::new_at_offset(*error.0, text_pos))
}
}