Split branches in heapsort child selection
This allows even better code-gen, cmp + adc. While also more clearly communicating the intent.
This commit is contained in:
parent
7e072199a6
commit
ee0376c368
@ -198,7 +198,12 @@ where
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Choose the greater child.
|
// Choose the greater child.
|
||||||
child += (child + 1 < v.len() && is_less(&v[child], &v[child + 1])) as usize;
|
if child + 1 < v.len() {
|
||||||
|
// We need a branch to be sure not to out-of-bounds index,
|
||||||
|
// but it's highly predictable. The comparison, however,
|
||||||
|
// is better done branchless, especially for primitives.
|
||||||
|
child += is_less(&v[child], &v[child + 1]) as usize;
|
||||||
|
}
|
||||||
|
|
||||||
// Stop if the invariant holds at `node`.
|
// Stop if the invariant holds at `node`.
|
||||||
if !is_less(&v[node], &v[child]) {
|
if !is_less(&v[node], &v[child]) {
|
||||||
|
Loading…
x
Reference in New Issue
Block a user