From ecdc8aae4193a4306b379803897ff367f1f65379 Mon Sep 17 00:00:00 2001
From: Brian Anderson <banderson@mozilla.com>
Date: Thu, 6 Dec 2012 19:12:25 -0800
Subject: [PATCH] Remove impl_id from trait_ref. Unused

---
 src/librustc/middle/typeck/collect.rs | 3 ---
 src/libsyntax/ast.rs                  | 2 +-
 src/libsyntax/ast_map.rs              | 6 ------
 src/libsyntax/ext/auto_serialize.rs   | 1 -
 src/libsyntax/ext/deriving.rs         | 3 +--
 src/libsyntax/fold.rs                 | 3 +--
 src/libsyntax/parse/parser.rs         | 2 +-
 7 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/src/librustc/middle/typeck/collect.rs b/src/librustc/middle/typeck/collect.rs
index ad21411d7cc..4c138d4c34a 100644
--- a/src/librustc/middle/typeck/collect.rs
+++ b/src/librustc/middle/typeck/collect.rs
@@ -647,9 +647,6 @@ fn convert_struct(ccx: @crate_ctxt,
     let cms = convert_methods(ccx, struct_def.methods, rp, bounds);
     for struct_def.traits.each |trait_ref| {
         check_methods_against_trait(ccx, tps, rp, selfty, *trait_ref, cms);
-        // trait_ref.impl_id represents (class, trait) pair
-        write_ty_to_tcx(tcx, trait_ref.impl_id, tpt.ty);
-        tcx.tcache.insert(local_def(trait_ref.impl_id), tpt);
     }
 
     // If this struct is enum-like or tuple-like, create the type of its
diff --git a/src/libsyntax/ast.rs b/src/libsyntax/ast.rs
index 1e7e427a384..134f5e68e92 100644
--- a/src/libsyntax/ast.rs
+++ b/src/libsyntax/ast.rs
@@ -1417,7 +1417,7 @@ type attribute_ = {style: attr_style, value: meta_item, is_sugared_doc: bool};
  */
 #[auto_serialize]
 #[auto_deserialize]
-type trait_ref = {path: @path, ref_id: node_id, impl_id: node_id};
+type trait_ref = {path: @path, ref_id: node_id};
 
 #[auto_serialize]
 #[auto_deserialize]
diff --git a/src/libsyntax/ast_map.rs b/src/libsyntax/ast_map.rs
index d04447e8d73..6d6e10b717e 100644
--- a/src/libsyntax/ast_map.rs
+++ b/src/libsyntax/ast_map.rs
@@ -254,9 +254,6 @@ fn map_item(i: @item, cx: ctx, v: vt) {
         // so we can find the self_ty
         for traits.each |p| {
             cx.map.insert(p.ref_id, node_item(i, item_path));
-            // This is so we can look up the right things when
-            // encoding/decoding
-            cx.map.insert(p.impl_id, node_item(i, item_path));
         }
         for (*methods).each |tm| {
             let id = ast_util::trait_method_to_ty_method(*tm).id;
@@ -282,9 +279,6 @@ fn map_struct_def(struct_def: @ast::struct_def, parent_node: ast_node,
     // so we can find the self_ty
     for struct_def.traits.each |p| {
         cx.map.insert(p.ref_id, parent_node);
-        // This is so we can look up the right things when
-        // encoding/decoding
-        cx.map.insert(p.impl_id, parent_node);
     }
     let d_id = ast_util::local_def(id);
     let p = extend(cx, ident);
diff --git a/src/libsyntax/ext/auto_serialize.rs b/src/libsyntax/ext/auto_serialize.rs
index a42a51fd302..7a1b973c3a1 100644
--- a/src/libsyntax/ext/auto_serialize.rs
+++ b/src/libsyntax/ext/auto_serialize.rs
@@ -393,7 +393,6 @@ fn mk_impl(
     let opt_trait = Some(@{
         path: path,
         ref_id: cx.next_id(),
-        impl_id: cx.next_id(),
     });
 
     let ty = cx.ty_path(
diff --git a/src/libsyntax/ext/deriving.rs b/src/libsyntax/ext/deriving.rs
index b8bb9c20dc0..2aca54446d7 100644
--- a/src/libsyntax/ext/deriving.rs
+++ b/src/libsyntax/ext/deriving.rs
@@ -220,8 +220,7 @@ fn create_derived_impl(cx: ext_ctxt,
     let trait_path = @move trait_path;
     let trait_ref = {
         path: trait_path,
-        ref_id: cx.next_id(),
-        impl_id: cx.next_id(),
+        ref_id: cx.next_id()
     };
     let trait_ref = @move trait_ref;
 
diff --git a/src/libsyntax/fold.rs b/src/libsyntax/fold.rs
index c69a2b62b18..59d4ac13ff2 100644
--- a/src/libsyntax/fold.rs
+++ b/src/libsyntax/fold.rs
@@ -280,8 +280,7 @@ fn fold_struct_def(struct_def: @ast::struct_def, fld: ast_fold)
 }
 
 fn fold_trait_ref(&&p: @trait_ref, fld: ast_fold) -> @trait_ref {
-    @{path: fld.fold_path(p.path), ref_id: fld.new_id(p.ref_id),
-     impl_id: fld.new_id(p.impl_id)}
+    @{path: fld.fold_path(p.path), ref_id: fld.new_id(p.ref_id)}
 }
 
 fn fold_struct_field(&&f: @struct_field, fld: ast_fold) -> @struct_field {
diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs
index 86907706bbf..36f5bbe4819 100644
--- a/src/libsyntax/parse/parser.rs
+++ b/src/libsyntax/parse/parser.rs
@@ -2821,7 +2821,7 @@ impl Parser {
 
     fn parse_trait_ref() -> @trait_ref {
         @{path: self.parse_path_with_tps(false),
-          ref_id: self.get_id(), impl_id: self.get_id()}
+          ref_id: self.get_id()}
     }
 
     fn parse_trait_ref_list(ket: token::Token) -> ~[@trait_ref] {