From a24dcd7babc7212a23eb5c8d7c73bede0d6465aa Mon Sep 17 00:00:00 2001 From: Veetaha Date: Wed, 15 Jan 2020 23:29:55 +0200 Subject: [PATCH 1/3] fix(ra_parser.typo): amend 'format language' to 'formal language' --- crates/ra_parser/src/grammar.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/ra_parser/src/grammar.rs b/crates/ra_parser/src/grammar.rs index 22f64a9f4ad..a46e11e1d94 100644 --- a/crates/ra_parser/src/grammar.rs +++ b/crates/ra_parser/src/grammar.rs @@ -1,7 +1,7 @@ //! This is the actual "grammar" of the Rust language. //! //! Each function in this module and its children corresponds -//! to a production of the format grammar. Submodules roughly +//! to a production of the formal grammar. Submodules roughly //! correspond to different *areas* of the grammar. By convention, //! each submodule starts with `use super::*` import and exports //! "public" productions via `pub(super)`. From 51fec39b825cfb91e42e7edb301b610e741af22c Mon Sep 17 00:00:00 2001 From: Veetaha Date: Thu, 16 Jan 2020 00:47:03 +0200 Subject: [PATCH 2/3] fix(xtask.gen_syntax.typo): add s to the verb that refers to the 3d person --- xtask/src/codegen/gen_syntax.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xtask/src/codegen/gen_syntax.rs b/xtask/src/codegen/gen_syntax.rs index 19fea67d8bf..db05dcebb01 100644 --- a/xtask/src/codegen/gen_syntax.rs +++ b/xtask/src/codegen/gen_syntax.rs @@ -1,4 +1,4 @@ -//! This module generate AST datatype used by rust-analyzer. +//! This module generates AST datatype used by rust-analyzer. //! //! Specifically, it generates the `SyntaxKind` enum and a number of newtype //! wrappers around `SyntaxNode` which implement `ra_syntax::AstNode`. From ecf3b3c9a1e9cd6a91412f0723a3107e65f92b91 Mon Sep 17 00:00:00 2001 From: Veetaha Date: Fri, 17 Jan 2020 01:31:03 +0200 Subject: [PATCH 3/3] todo(codegen): added todo to change the reference to removed ra_tools crate --- xtask/src/lib.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/xtask/src/lib.rs b/xtask/src/lib.rs index 0a569cf5dc6..9b0afe8e0cf 100644 --- a/xtask/src/lib.rs +++ b/xtask/src/lib.rs @@ -53,6 +53,7 @@ fn reformat(text: impl std::fmt::Display) -> Result { write!(rustfmt.stdin.take().unwrap(), "{}", text)?; let output = rustfmt.wait_with_output()?; let stdout = String::from_utf8(output.stdout)?; + // TODO: update the preable: replace ra_tools with the relevant path let preamble = "Generated file, do not edit by hand, see `crate/ra_tools/src/codegen`"; Ok(format!("//! {}\n\n{}", preamble, stdout)) }