mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

11973: Don't escape " in '"'

Browse Source
This commit is contained in:
Florian Brucker 2023-12-27 22:15:17 +01:00
parent 7343db9ce3
commit e5c9fb6827
4 changed files with 21 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
clippy_lints/src/methods/utils.rs
View File

@ -74,6 +74,7 @@ pub(super) fn get_hint_if_single_char_arg(
match ch {
"'" => "\\'",
r"\" => "\\\\",
"\\\"" => "\"", // no need to escape `"` in `'"'`
_ => ch,
}
);

2
tests/ui/single_char_pattern.fixed
View File

@ -42,6 +42,8 @@ fn main() {
x.split('\n');
x.split('\'');
x.split('\'');
// Issue #11973: Don't escape `"` in `'"'`
x.split('"');
let h = HashSet::<String>::new();
h.contains("X"); // should not warn

2
tests/ui/single_char_pattern.rs
View File

@ -42,6 +42,8 @@ fn main() {
x.split("\n");
x.split("'");
x.split("\'");
// Issue #11973: Don't escape `"` in `'"'`
x.split("\"");
let h = HashSet::<String>::new();
h.contains("X"); // should not warn

26
tests/ui/single_char_pattern.stderr
View File

@ -182,58 +182,64 @@ LL | x.split("\'");
| ^^^^ help: try using a `char` instead: `'\''`
error: single-character string constant used as pattern
--> $DIR/single_char_pattern.rs:49:31
--> $DIR/single_char_pattern.rs:46:13
|
LL | x.split("\"");
| ^^^^ help: try using a `char` instead: `'"'`
error: single-character string constant used as pattern
--> $DIR/single_char_pattern.rs:51:31
|
LL | x.replace(';', ",").split(","); // issue #2978
| ^^^ help: try using a `char` instead: `','`
error: single-character string constant used as pattern
--> $DIR/single_char_pattern.rs:50:19
--> $DIR/single_char_pattern.rs:52:19
|
LL | x.starts_with("\x03"); // issue #2996
| ^^^^^^ help: try using a `char` instead: `'\x03'`
error: single-character string constant used as pattern
--> $DIR/single_char_pattern.rs:57:13
--> $DIR/single_char_pattern.rs:59:13
|
LL | x.split(r"a");
| ^^^^ help: try using a `char` instead: `'a'`
error: single-character string constant used as pattern
--> $DIR/single_char_pattern.rs:58:13
--> $DIR/single_char_pattern.rs:60:13
|
LL | x.split(r#"a"#);
| ^^^^^^ help: try using a `char` instead: `'a'`
error: single-character string constant used as pattern
--> $DIR/single_char_pattern.rs:59:13
--> $DIR/single_char_pattern.rs:61:13
|
LL | x.split(r###"a"###);
| ^^^^^^^^^^ help: try using a `char` instead: `'a'`
error: single-character string constant used as pattern
--> $DIR/single_char_pattern.rs:60:13
--> $DIR/single_char_pattern.rs:62:13
|
LL | x.split(r###"'"###);
| ^^^^^^^^^^ help: try using a `char` instead: `'\''`
error: single-character string constant used as pattern
--> $DIR/single_char_pattern.rs:61:13
--> $DIR/single_char_pattern.rs:63:13
|
LL | x.split(r###"#"###);
| ^^^^^^^^^^ help: try using a `char` instead: `'#'`
error: single-character string constant used as pattern
--> $DIR/single_char_pattern.rs:63:13
--> $DIR/single_char_pattern.rs:65:13
|
LL | x.split(r#"\"#);
| ^^^^^^ help: try using a `char` instead: `'\\'`
error: single-character string constant used as pattern
--> $DIR/single_char_pattern.rs:64:13
--> $DIR/single_char_pattern.rs:66:13
|
LL | x.split(r"\");
| ^^^^ help: try using a `char` instead: `'\\'`
error: aborting due to 39 previous errors
error: aborting due to 40 previous errors