UB if f*_fast intrinsic called with nonfinite value

This commit is contained in:
Smitty 2021-05-02 12:25:00 -04:00
parent 0e3038571c
commit e591b83185
4 changed files with 51 additions and 0 deletions

View File

@ -173,6 +173,36 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
"frem_fast" => mir::BinOp::Rem,
_ => bug!(),
};
let a_valid = match a.layout.ty.kind() {
ty::Float(FloatTy::F32) => a.to_scalar()?.to_f32()?.is_finite(),
ty::Float(FloatTy::F64) => a.to_scalar()?.to_f64()?.is_finite(),
_ => bug!(
"`{}` called with non-float input type {:?}",
intrinsic_name,
a.layout.ty
),
};
if !a_valid {
throw_ub_format!(
"`{}` intrinsic called with non-finite value as first parameter",
intrinsic_name,
);
}
let b_valid = match b.layout.ty.kind() {
ty::Float(FloatTy::F32) => b.to_scalar()?.to_f32()?.is_finite(),
ty::Float(FloatTy::F64) => b.to_scalar()?.to_f64()?.is_finite(),
_ => bug!(
"`{}` called with non-float input type {:?}",
intrinsic_name,
b.layout.ty
),
};
if !b_valid {
throw_ub_format!(
"`{}` intrinsic called with non-finite value as second parameter",
intrinsic_name,
);
}
this.binop_ignore_overflow(op, &a, &b, dest)?;
}

View File

@ -0,0 +1,7 @@
#![feature(core_intrinsics)]
fn main() {
unsafe {
let _x: f32 = core::intrinsics::frem_fast(f32::NAN, 3.2); //~ ERROR `frem_fast` intrinsic called with non-finite value as first parameter
}
}

View File

@ -0,0 +1,7 @@
#![feature(core_intrinsics)]
fn main() {
unsafe {
let _x: f32 = core::intrinsics::fsub_fast(f32::NAN, f32::NAN); //~ ERROR `fsub_fast` intrinsic called with non-finite value as first parameter
}
}

View File

@ -0,0 +1,7 @@
#![feature(core_intrinsics)]
fn main() {
unsafe {
let _x: f32 = core::intrinsics::fmul_fast(3.4f32, f32::NAN); //~ ERROR `fmul_fast` intrinsic called with non-finite value as second parameter
}
}