mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto merge of #12372 - GuillaumeGomez:fix-nonminimal_bool-regression, r=flip1995

Browse Source 
Fix `nonminimal_bool` lint regression

Fixes #12371.
Fixes #12369.

cc `@RalfJung`

The problem was an invalid condition. Shame on me...

changelog: Fix `nonminimal_bool` lint regression
This commit is contained in:
bors 2024-02-28 15:30:49 +00:00
commit e450a27a20
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clippy_lints/src/booleans.rs
View File

@ -148,8 +148,8 @@ fn check_inverted_bool_in_condition(
right: &Expr<'_>, right: &Expr<'_>,
) { ) {
if expr_span.from_expansion() if expr_span.from_expansion()
&& (!cx.typeck_results().node_types()[left.hir_id].is_bool() || !cx.typeck_results().node_types()[left.hir_id].is_bool()
|| !cx.typeck_results().node_types()[right.hir_id].is_bool()) || !cx.typeck_results().node_types()[right.hir_id].is_bool()
{ {
return; return;
} }

5
tests/ui/nonminimal_bool.rs
View File

@ -173,3 +173,8 @@ fn issue_5794() {
if !b == !c {} //~ ERROR: this boolean expression can be simplified if !b == !c {} //~ ERROR: this boolean expression can be simplified
if !b != !c {} //~ ERROR: this boolean expression can be simplified if !b != !c {} //~ ERROR: this boolean expression can be simplified
} }
fn issue_12371(x: usize) -> bool {
// Should not warn!
!x != 0
}