Fixed test

This commit is contained in:
Pierre-Andre Gagnon 2021-02-02 19:14:13 -05:00
parent bfbc083587
commit e0e51e4189
3 changed files with 116 additions and 8 deletions

View File

@ -140,7 +140,7 @@ fn check_fn(
UNNECESSARY_WRAPS,
fn_decl.output.span(),
"unneeded wrapped unit return type",
format!("remove the `-> {}<()>`", return_type_label).as_str(),
format!("remove the `-> {}<[...]>`", return_type_label).as_str(),
String::new(),
Applicability::MaybeIncorrect,
);

View File

@ -135,7 +135,6 @@ fn issue_6640_2(a: bool, b: bool) -> Result<(), i32> {
return Ok(());
}
if a {
Ok(());
Ok(())
} else {
return Ok(());

View File

@ -1,9 +1,118 @@
error[E0282]: type annotations needed
--> $DIR/unnecessary_wraps.rs:138:9
error: this function's return value is unnecessarily wrapped by `Option`
--> $DIR/unnecessary_wraps.rs:8:1
|
LL | Ok(());
| ^^ cannot infer type for type parameter `E` declared on the enum `Result`
LL | / fn func1(a: bool, b: bool) -> Option<i32> {
LL | | if a && b {
LL | | return Some(42);
LL | | }
... |
LL | | }
LL | | }
| |_^
|
= note: `-D clippy::unnecessary-wraps` implied by `-D warnings`
help: remove `Option` from the return type...
|
LL | fn func1(a: bool, b: bool) -> i32 {
| ^^^
help: ...and change the returning expressions
|
LL | return 42;
LL | }
LL | if a {
LL | Some(-1);
LL | 2
LL | } else {
...
error: aborting due to previous error
error: this function's return value is unnecessarily wrapped by `Option`
--> $DIR/unnecessary_wraps.rs:21:1
|
LL | / fn func2(a: bool, b: bool) -> Option<i32> {
LL | | if a && b {
LL | | return Some(10);
LL | | }
... |
LL | | }
LL | | }
| |_^
|
help: remove `Option` from the return type...
|
LL | fn func2(a: bool, b: bool) -> i32 {
| ^^^
help: ...and change the returning expressions
|
LL | return 10;
LL | }
LL | if a {
LL | 20
LL | } else {
LL | 30
|
error: this function's return value is unnecessarily wrapped by `Option`
--> $DIR/unnecessary_wraps.rs:51:1
|
LL | / fn func5() -> Option<i32> {
LL | | Some(1)
LL | | }
| |_^
|
help: remove `Option` from the return type...
|
LL | fn func5() -> i32 {
| ^^^
help: ...and change the returning expressions
|
LL | 1
|
error: this function's return value is unnecessarily wrapped by `Result`
--> $DIR/unnecessary_wraps.rs:61:1
|
LL | / fn func7() -> Result<i32, ()> {
LL | | Ok(1)
LL | | }
| |_^
|
help: remove `Result` from the return type...
|
LL | fn func7() -> i32 {
| ^^^
help: ...and change the returning expressions
|
LL | 1
|
error: this function's return value is unnecessarily wrapped by `Option`
--> $DIR/unnecessary_wraps.rs:93:5
|
LL | / fn func12() -> Option<i32> {
LL | | Some(1)
LL | | }
| |_____^
|
help: remove `Option` from the return type...
|
LL | fn func12() -> i32 {
| ^^^
help: ...and change the returning expressions
|
LL | 1
|
error: unneeded wrapped unit return type
--> $DIR/unnecessary_wraps.rs:120:38
|
LL | fn issue_6640_1(a: bool, b: bool) -> Option<()> {
| ^^^^^^^^^^ help: remove the `-> Option<[...]>`
error: unneeded wrapped unit return type
--> $DIR/unnecessary_wraps.rs:133:38
|
LL | fn issue_6640_2(a: bool, b: bool) -> Result<(), i32> {
| ^^^^^^^^^^^^^^^ help: remove the `-> Result<[...]>`
error: aborting due to 7 previous errors
For more information about this error, try `rustc --explain E0282`.