core: Stamp out XXXes (comments only)

This commit is contained in:
Tim Chevalier 2013-01-31 19:34:46 -08:00
parent 2de8e8f81a
commit e0281d991c
4 changed files with 5 additions and 5 deletions

View File

@ -145,7 +145,7 @@ pub mod win32 {
/* /*
Accessing environment variables is not generally threadsafe. Accessing environment variables is not generally threadsafe.
This uses a per-runtime lock to serialize access. This uses a per-runtime lock to serialize access.
XXX: It would probably be appropriate to make this a real global FIXME #4726: It would probably be appropriate to make this a real global
*/ */
fn with_env_lock<T>(f: &fn() -> T) -> T { fn with_env_lock<T>(f: &fn() -> T) -> T {
use private::global::global_data_clone_create; use private::global::global_data_clone_create;

View File

@ -31,7 +31,7 @@ pub trait Finally<T> {
} }
impl<T> &fn() -> T: Finally<T> { impl<T> &fn() -> T: Finally<T> {
// XXX: Should not require a mode here // FIXME #4518: Should not require a mode here
fn finally(&self, +dtor: &fn()) -> T { fn finally(&self, +dtor: &fn()) -> T {
let _d = Finallyalizer { let _d = Finallyalizer {
dtor: dtor dtor: dtor
@ -88,7 +88,7 @@ fn test_retval() {
#[test] #[test]
fn test_compact() { fn test_compact() {
// XXX Should be able to use a fn item instead // FIXME #4727: Should be able to use a fn item instead
// of a closure for do_some_fallible_work, // of a closure for do_some_fallible_work,
// but it's a type error. // but it's a type error.
let do_some_fallible_work: &fn() = || { }; let do_some_fallible_work: &fn() = || { };

View File

@ -160,7 +160,7 @@ fn get_global_state() -> Exclusive<GlobalState> {
const POISON: int = -1; const POISON: int = -1;
// XXX: Doing atomic_cxchg to initialize the global state // FIXME #4728: Doing atomic_cxchg to initialize the global state
// lazily, which wouldn't be necessary with a runtime written // lazily, which wouldn't be necessary with a runtime written
// in Rust // in Rust
let global_ptr = unsafe { rust_get_global_data_ptr() }; let global_ptr = unsafe { rust_get_global_data_ptr() };

View File

@ -30,7 +30,7 @@ use ops::Drop;
type ShutdownMsg = (); type ShutdownMsg = ();
// XXX: This could be a PortOne but I've experienced bugginess // FIXME #4729: This could be a PortOne but I've experienced bugginess
// with oneshot pipes and try_send // with oneshot pipes and try_send
pub unsafe fn weaken_task(f: &fn(Port<ShutdownMsg>)) { pub unsafe fn weaken_task(f: &fn(Port<ShutdownMsg>)) {
let service = global_data_clone_create(global_data_key, let service = global_data_clone_create(global_data_key,