mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make lint description easier to read, prevent ICE

Browse Source
This commit is contained in:
y21 2023-06-08 12:42:12 +02:00
parent 7aa4babb5c
commit de7d43bc61
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
clippy_lints/src/large_stack_frames.rs
View File

@ -1,6 +1,7 @@
use std::ops::AddAssign; use std::ops::AddAssign;
use clippy_utils::diagnostics::span_lint_and_note; use clippy_utils::diagnostics::span_lint_and_note;
use clippy_utils::fn_has_unsatisfiable_preds;
use rustc_hir::def_id::LocalDefId; use rustc_hir::def_id::LocalDefId;
use rustc_hir::intravisit::FnKind; use rustc_hir::intravisit::FnKind;
use rustc_hir::Body; use rustc_hir::Body;
@ -27,7 +28,7 @@ declare_clippy_lint! {
/// ///
/// Keep in mind that the code path to construction of large types does not even need to be reachable; /// Keep in mind that the code path to construction of large types does not even need to be reachable;
/// it purely needs to *exist* inside of the function to contribute to the stack size. /// it purely needs to *exist* inside of the function to contribute to the stack size.
/// For example, this causes a stack overflow even though the branch is unreachable (with `-Zmir-opt-level=0`): /// For example, this causes a stack overflow even though the branch is unreachable:
/// ```rust,ignore /// ```rust,ignore
/// fn main() { /// fn main() {
/// if false { /// if false {
@ -43,11 +44,9 @@ declare_clippy_lint! {
/// Modern compilers are very smart and are able to optimize away a lot of unnecessary stack allocations. /// Modern compilers are very smart and are able to optimize away a lot of unnecessary stack allocations.
/// In debug mode however, it is usually more accurate. /// In debug mode however, it is usually more accurate.
/// ///
/// This lint works by summing up the size of all locals and comparing them against a (configurable, but high-by-default) /// This lint works by summing up the size of all variables that the user typed, variables that were
/// threshold. /// implicitly introduced by the compiler for temporaries, function arguments and the return value,
/// Note that "locals" in this context refers to [MIR locals](https://rustc-dev-guide.rust-lang.org/mir/index.html#key-mir-vocabulary), /// and comparing them against a (configurable, but high-by-default).
/// i.e. real local variables that the user typed, storage for temporary values, function arguments
/// and the return value.
/// ///
/// ### Example /// ### Example
/// This function creates four 500 KB arrays on the stack. Quite big but just small enough to not trigger `large_stack_arrays`. /// This function creates four 500 KB arrays on the stack. Quite big but just small enough to not trigger `large_stack_arrays`.
@ -133,6 +132,10 @@ impl<'tcx> LateLintPass<'tcx> for LargeStackFrames {
local_def_id: LocalDefId, local_def_id: LocalDefId,
) { ) {
let def_id = local_def_id.to_def_id(); let def_id = local_def_id.to_def_id();
// Building MIR for `fn`s with unsatisfiable preds results in ICE.
if fn_has_unsatisfiable_preds(cx, def_id) {
return;
}
let mir = cx.tcx.optimized_mir(def_id); let mir = cx.tcx.optimized_mir(def_id);
let param_env = cx.tcx.param_env(def_id); let param_env = cx.tcx.param_env(def_id);