From dbb978a3c6d0503d188f11bbd4e53aac74d98bda Mon Sep 17 00:00:00 2001 From: Noah Lev Date: Sun, 25 Jul 2021 16:28:52 -0700 Subject: [PATCH] Remove unnecessary `structhead` parameter from `render_union` `structhead` is used for `render_struct` so that the logic for rendering structs can be shared between struct variants and struct items. However, `render_union` is not used anywhere except for rendering union items, so its `structhead` parameter is unnecessary. --- src/librustdoc/html/render/print_item.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/librustdoc/html/render/print_item.rs b/src/librustdoc/html/render/print_item.rs index 2dfbaff1cc9..9d6e34caa07 100644 --- a/src/librustdoc/html/render/print_item.rs +++ b/src/librustdoc/html/render/print_item.rs @@ -888,7 +888,7 @@ fn item_union(w: &mut Buffer, cx: &Context<'_>, it: &clean::Item, s: &clean::Uni wrap_into_docblock(w, |w| { w.write_str("
");
         render_attributes_in_pre(w, it, "");
-        render_union(w, it, Some(&s.generics), &s.fields, "", true, cx);
+        render_union(w, it, Some(&s.generics), &s.fields, "", cx);
         w.write_str("
") }); @@ -1380,14 +1380,12 @@ fn render_union( g: Option<&clean::Generics>, fields: &[clean::Item], tab: &str, - structhead: bool, cx: &Context<'_>, ) { write!( w, - "{}{}{}", + "{}union {}", it.visibility.print_with_space(it.def_id, cx), - if structhead { "union " } else { "" }, it.name.as_ref().unwrap() ); if let Some(g) = g {