diff --git a/crates/hir/src/source_analyzer.rs b/crates/hir/src/source_analyzer.rs index 8f6c3d995fa..e14cd43ede8 100644 --- a/crates/hir/src/source_analyzer.rs +++ b/crates/hir/src/source_analyzer.rs @@ -252,7 +252,9 @@ pub(crate) fn resolve_path( db: &dyn HirDatabase, path: &ast::Path, ) -> Option { - let parent = || path.syntax().parent(); + let parent = path.syntax().parent(); + let parent = || parent.clone(); + let mut prefer_value_ns = false; if let Some(path_expr) = parent().and_then(ast::PathExpr::cast) { let expr_id = self.expr_id(db, &path_expr.into())?; @@ -337,10 +339,10 @@ pub(crate) fn resolve_path( return match res { Some(_) => res.map(PathResolution::Macro), None => path.as_single_name_ref().and_then(|name_ref| { - if let Some(builtin) = BuiltinAttr::by_name(&name_ref.text()) { - Some(PathResolution::BuiltinAttr(builtin)) - } else if let Some(tool) = Tool::by_name(&name_ref.text()) { - Some(PathResolution::Tool(tool)) + if let builtin @ Some(_) = BuiltinAttr::by_name(&name_ref.text()) { + builtin.map(PathResolution::BuiltinAttr) + } else if let tool @ Some(_) = Tool::by_name(&name_ref.text()) { + tool.map(PathResolution::Tool) } else { None } @@ -355,6 +357,8 @@ pub(crate) fn resolve_path( }; match res { Some(_) => res, + // this labels any path that starts with a tool module as the tool itself, this is technically wrong + // but there is no benefit in differentiating these two cases for the time being None if is_path_of_attr => path .first_segment() .and_then(|seg| seg.name_ref()) diff --git a/crates/ide/src/syntax_highlighting/test_data/highlighting.html b/crates/ide/src/syntax_highlighting/test_data/highlighting.html index da607b51211..370f58080e6 100644 --- a/crates/ide/src/syntax_highlighting/test_data/highlighting.html +++ b/crates/ide/src/syntax_highlighting/test_data/highlighting.html @@ -43,6 +43,7 @@ pre { color: #DCDCCC; background: #3F3F3F; font-size: 22px; padd
use inner::{self as inner_mod};
 mod inner {}
 
+#[allow()]
 #[proc_macros::identity]
 pub mod ops {
     #[lang = "fn_once"]
diff --git a/crates/ide/src/syntax_highlighting/tests.rs b/crates/ide/src/syntax_highlighting/tests.rs
index e74f39a8650..63a1417c6aa 100644
--- a/crates/ide/src/syntax_highlighting/tests.rs
+++ b/crates/ide/src/syntax_highlighting/tests.rs
@@ -16,6 +16,7 @@ fn test_highlighting() {
 use inner::{self as inner_mod};
 mod inner {}
 
+#[allow()]
 #[proc_macros::identity]
 pub mod ops {
     #[lang = "fn_once"]