mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #97645 - lcnr:derived-impl-debug, r=cjgillot

Browse Source 
don't use a `span_note` for ignored impls

Searching for the `derive` isn't too difficult as it's right above the field definition.

By using a span these errors are a lot more verbose than they should be, which is especially annoying as one can end up with a lot of `dead_code` warnings.
This commit is contained in:
Matthias Krüger 2022-06-02 23:39:06 +02:00 committed by GitHub
commit d1ae3a4c3b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
compiler/rustc_passes/src/dead.rs
View File

@ -722,11 +722,7 @@ impl<'tcx> DeadVisitor<'tcx> {
traits_str, traits_str,
is_are is_are
); );
let multispan = ign_traits err.note(&msg);
.iter()
.map(|(_, impl_id)| self.tcx.def_span(*impl_id))
.collect::<Vec<_>>();
err.span_note(multispan, &msg);
} }
err.emit(); err.emit();
}); });

7
src/test/ui/derive-uninhabited-enum-38885.stderr
View File

@ -5,12 +5,7 @@ LL | Void(Void),
| ^^^^^^^^^^ | ^^^^^^^^^^
| |
= note: `-W dead-code` implied by `-W unused` = note: `-W dead-code` implied by `-W unused`
note: `Foo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `Foo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
--> $DIR/derive-uninhabited-enum-38885.rs:10:10
|
LL | #[derive(Debug)]
| ^^^^^
= note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: 1 warning emitted warning: 1 warning emitted

21
src/test/ui/derives/clone-debug-dead-code.stderr
View File

@ -16,12 +16,7 @@ error: field is never read: `f`
LL | struct B { f: () } LL | struct B { f: () }
| ^^^^^ | ^^^^^
| |
note: `B` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis = note: `B` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
--> $DIR/clone-debug-dead-code.rs:9:10
|
LL | #[derive(Clone)]
| ^^^^^
= note: this error originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info)
error: field is never read: `f` error: field is never read: `f`
--> $DIR/clone-debug-dead-code.rs:14:12 --> $DIR/clone-debug-dead-code.rs:14:12
@ -29,12 +24,7 @@ error: field is never read: `f`
LL | struct C { f: () } LL | struct C { f: () }
| ^^^^^ | ^^^^^
| |
note: `C` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `C` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
--> $DIR/clone-debug-dead-code.rs:13:10
|
LL | #[derive(Debug)]
| ^^^^^
= note: this error originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)
error: field is never read: `f` error: field is never read: `f`
--> $DIR/clone-debug-dead-code.rs:18:12 --> $DIR/clone-debug-dead-code.rs:18:12
@ -42,12 +32,7 @@ error: field is never read: `f`
LL | struct D { f: () } LL | struct D { f: () }
| ^^^^^ | ^^^^^
| |
note: `D` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `D` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
--> $DIR/clone-debug-dead-code.rs:17:10
|
LL | #[derive(Debug,Clone)]
| ^^^^^ ^^^^^
= note: this error originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)
error: field is never read: `f` error: field is never read: `f`
--> $DIR/clone-debug-dead-code.rs:21:12 --> $DIR/clone-debug-dead-code.rs:21:12

7
src/test/ui/lint/dead-code/unused-variant.stderr
View File

@ -9,12 +9,7 @@ note: the lint level is defined here
| |
LL | #![deny(dead_code)] LL | #![deny(dead_code)]
| ^^^^^^^^^ | ^^^^^^^^^
note: `Enum` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis = note: `Enum` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
--> $DIR/unused-variant.rs:3:10
|
LL | #[derive(Clone)]
| ^^^^^
= note: this error originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info)
error: aborting due to previous error error: aborting due to previous error