mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not suggest adjusting trait signature on type mismatch

Browse Source
This commit is contained in:
Michael Goulet 2023-06-10 22:51:00 +00:00
parent 0f7ef1a202
commit d1ab6c2ae3
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
View File

@ -3959,6 +3959,10 @@ fn hint_missing_borrow<'tcx>(
found_node: Node<'_>, found_node: Node<'_>,
err: &mut Diagnostic, err: &mut Diagnostic,
) { ) {
if matches!(found_node, Node::TraitItem(..)) {
return;
}
let found_args = match found.kind() { let found_args = match found.kind() {
ty::FnPtr(f) => infcx.instantiate_binder_with_placeholders(*f).inputs().iter(), ty::FnPtr(f) => infcx.instantiate_binder_with_placeholders(*f).inputs().iter(),
kind => { kind => {

5
tests/ui/typeck/mismatched-map-under-self.stderr
View File

@ -30,11 +30,6 @@ LL | self.map(Insertable::values).unwrap_or_default()
found function signature `for<'a> fn(&'a _) -> _` found function signature `for<'a> fn(&'a _) -> _`
note: required by a bound in `Option::<T>::map` note: required by a bound in `Option::<T>::map`
--> $SRC_DIR/core/src/option.rs:LL:COL --> $SRC_DIR/core/src/option.rs:LL:COL
help: consider adjusting the signature so it does not borrow its argument
|
LL - fn values(&self) -> Self::Values;
LL + fn values(self) -> Self::Values;
|
error: aborting due to 2 previous errors error: aborting due to 2 previous errors