mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge #2722

Browse Source 
2722: Fix ra_cargo_watch test on windows. r=matklad a=kiljacken

Due to difference in path parsing on platforms, the current input to the snapshot tests in ra_cargo_watch cause a panic when running on Windows. This PR disables the tests when running on Windows until a better solution is found.

If somebody running on Windows could test this that would be great, as I'm working in the blind here :) 

Fixes #2720 (probably).

Co-authored-by: Emil Lauridsen <mine809@gmail.com>
This commit is contained in:
bors[bot] 2020-01-01 22:25:37 +00:00 committed by GitHub
commit cf67c74213
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crates/ra_cargo_watch/src/conv/test.rs
View File

@ -7,6 +7,7 @@ fn parse_diagnostic(val: &str) -> cargo_metadata::diagnostic::Diagnostic {
}
#[test]
#[cfg(not(windows))]
fn snap_rustc_incompatible_type_for_trait() {
let diag = parse_diagnostic(
r##"{
@ -60,6 +61,7 @@ fn snap_rustc_incompatible_type_for_trait() {
}
#[test]
#[cfg(not(windows))]
fn snap_rustc_unused_variable() {
let diag = parse_diagnostic(
r##"{
@ -142,6 +144,7 @@ fn snap_rustc_unused_variable() {
}
#[test]
#[cfg(not(windows))]
fn snap_rustc_wrong_number_of_parameters() {
let diag = parse_diagnostic(
r##"{
@ -266,6 +269,7 @@ fn snap_rustc_wrong_number_of_parameters() {
}
#[test]
#[cfg(not(windows))]
fn snap_clippy_pass_by_ref() {
let diag = parse_diagnostic(
r##"{
@ -386,6 +390,7 @@ fn snap_clippy_pass_by_ref() {
}
#[test]
#[cfg(not(windows))]
fn snap_rustc_mismatched_type() {
let diag = parse_diagnostic(
r##"{
@ -429,6 +434,7 @@ fn snap_rustc_mismatched_type() {
}
#[test]
#[cfg(not(windows))]
fn snap_handles_macro_location() {
let diag = parse_diagnostic(
r##"{
@ -700,6 +706,7 @@ fn snap_handles_macro_location() {
}
#[test]
#[cfg(not(windows))]
fn snap_macro_compiler_error() {
let diag = parse_diagnostic(
r##"{