mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure no one re-adds Partial/Ord impls for DefId

Browse Source
This commit is contained in:
Oli Scherer 2024-03-21 17:24:49 +00:00
parent 5f4ac61ebd
commit cf3ab41c83
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
compiler/rustc_span/src/def_id.rs
View File

@ -234,6 +234,12 @@ pub struct DefId {
pub index: DefIndex, pub index: DefIndex,
} }
// To ensure correctness of incremental compilation,
// `DefId` must not implement `Ord` or `PartialOrd`.
// See https://github.com/rust-lang/rust/issues/90317.
impl !Ord for DefId {}
impl !PartialOrd for DefId {}
// On 64-bit systems, we can hash the whole `DefId` as one `u64` instead of two `u32`s. This // On 64-bit systems, we can hash the whole `DefId` as one `u64` instead of two `u32`s. This
// improves performance without impairing `FxHash` quality. So the below code gets compiled to a // improves performance without impairing `FxHash` quality. So the below code gets compiled to a
// noop on little endian systems because the memory layout of `DefId` is as follows: // noop on little endian systems because the memory layout of `DefId` is as follows: