Remove casts from FullInt impl

2021-10-30 06:22:19 +02:00 · 2021-10-30 06:22:19 +02:00 · c8edd9a16e
commit c8edd9a16e
parent 665ff57fde
1 changed files with 1 additions and 8 deletions
--- a/clippy_utils/src/consts.rs
+++ b/clippy_utils/src/consts.rs
@ -230,16 +230,9 @@ pub enum FullInt {
 }

 impl FullInt {
-    #[allow(clippy::cast_sign_loss)]
    #[must_use]
    fn cmp_s_u(s: i128, u: u128) -> Ordering {
-        if s < 0 {
-            Ordering::Less
-        } else if u > (i128::MAX as u128) {
-            Ordering::Greater
-        } else {
-            (s as u128).cmp(&u)
-        }
+        u128::try_from(s).map_or(Ordering::Less, |x| x.cmp(&u))
    }
 }