Auto merge of #122204 - pnkfelix:downgrade-const-eval-dnagling-ptr-in-final-to-future-incompat-lint, r=wesleywiser
Downgrade const eval dangling ptr in final to future incompat lint Short term band-aid for issue #121610, downgrading the prior hard error to a future-incompat lint (tracked in issue #122153). Note we should not mark #121610 as resolved until after this (or something analogous) is beta backported.
This commit is contained in:
bors
commit
c7fed9f854
@ -25,10 +25,13 @@ pub(crate) struct DanglingPtrInFinal {
|
||||
pub kind: InternKind,
|
||||
}
|
||||
|
||||
#[derive(Diagnostic)]
|
||||
#[derive(LintDiagnostic)]
|
||||
#[diag(const_eval_mutable_ptr_in_final)]
|
||||
pub(crate) struct MutablePtrInFinal {
|
||||
#[primary_span]
|
||||
// rust-lang/rust#122153: This was marked as `#[primary_span]` under
|
||||
// `derive(Diagnostic)`. Since we expect we may hard-error in future, we are
|
||||
// keeping the field (and skipping it under `derive(LintDiagnostic)`).
|
||||
#[skip_arg]
|
||||
pub span: Span,
|
||||
pub kind: InternKind,
|
||||
}
|
||||
|
||||
@ -21,6 +21,7 @@ use rustc_hir as hir;
|
||||
use rustc_middle::mir::interpret::{ConstAllocation, CtfeProvenance, InterpResult};
|
||||
use rustc_middle::query::TyCtxtAt;
|
||||
use rustc_middle::ty::layout::TyAndLayout;
|
||||
use rustc_session::lint;
|
||||
use rustc_span::def_id::LocalDefId;
|
||||
use rustc_span::sym;
|
||||
|
||||
@ -262,10 +263,13 @@ pub fn intern_const_alloc_recursive<
|
||||
})?);
|
||||
}
|
||||
if found_bad_mutable_pointer {
|
||||
return Err(ecx
|
||||
.tcx
|
||||
.dcx()
|
||||
.emit_err(MutablePtrInFinal { span: ecx.tcx.span, kind: intern_kind }));
|
||||
let err_diag = MutablePtrInFinal { span: ecx.tcx.span, kind: intern_kind };
|
||||
ecx.tcx.emit_node_span_lint(
|
||||
lint::builtin::CONST_EVAL_MUTABLE_PTR_IN_FINAL_VALUE,
|
||||
ecx.best_lint_scope(),
|
||||
err_diag.span,
|
||||
err_diag,
|
||||
)
|
||||
}
|
||||
|
||||
Ok(())
|
||||
|
||||
@ -30,6 +30,7 @@ declare_lint_pass! {
|
||||
CENUM_IMPL_DROP_CAST,
|
||||
COHERENCE_LEAK_CHECK,
|
||||
CONFLICTING_REPR_HINTS,
|
||||
CONST_EVAL_MUTABLE_PTR_IN_FINAL_VALUE,
|
||||
CONST_EVALUATABLE_UNCHECKED,
|
||||
CONST_ITEM_MUTATION,
|
||||
DEAD_CODE,
|
||||
@ -2796,6 +2797,51 @@ declare_lint! {
|
||||
@feature_gate = sym::strict_provenance;
|
||||
}
|
||||
|
||||
declare_lint! {
|
||||
/// The `const_eval_mutable_ptr_in_final_value` lint detects if a mutable pointer
|
||||
/// has leaked into the final value of a const expression.
|
||||
///
|
||||
/// ### Example
|
||||
///
|
||||
/// ```rust
|
||||
/// pub enum JsValue {
|
||||
/// Undefined,
|
||||
/// Object(std::cell::Cell<bool>),
|
||||
/// }
|
||||
///
|
||||
/// impl ::std::ops::Drop for JsValue {
|
||||
/// fn drop(&mut self) {}
|
||||
/// }
|
||||
///
|
||||
/// const UNDEFINED: &JsValue = &JsValue::Undefined;
|
||||
///
|
||||
/// fn main() {
|
||||
/// }
|
||||
/// ```
|
||||
///
|
||||
/// {{produces}}
|
||||
///
|
||||
/// ### Explanation
|
||||
///
|
||||
/// In the 1.77 release, the const evaluation machinery adopted some
|
||||
/// stricter rules to reject expressions with values that could
|
||||
/// end up holding mutable references to state stored in static memory
|
||||
/// (which is inherently immutable).
|
||||
///
|
||||
/// This is a [future-incompatible] lint to ease the transition to an error.
|
||||
/// See [issue #122153] for more details.
|
||||
///
|
||||
/// [issue #122153]: https://github.com/rust-lang/rust/issues/122153
|
||||
/// [future-incompatible]: ../index.md#future-incompatible-lints
|
||||
pub CONST_EVAL_MUTABLE_PTR_IN_FINAL_VALUE,
|
||||
Warn,
|
||||
"detects a mutable pointer that has leaked into final value of a const expression",
|
||||
@future_incompatible = FutureIncompatibleInfo {
|
||||
reason: FutureIncompatibilityReason::FutureReleaseErrorReportInDeps,
|
||||
reference: "issue #122153 <https://github.com/rust-lang/rust/issues/122153>",
|
||||
};
|
||||
}
|
||||
|
||||
declare_lint! {
|
||||
/// The `const_evaluatable_unchecked` lint detects a generic constant used
|
||||
/// in a type.
|
||||
|
||||
@ -1,9 +1,11 @@
|
||||
#![feature(core_intrinsics)]
|
||||
#![feature(const_heap)]
|
||||
#![feature(const_mut_refs)]
|
||||
#![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
use std::intrinsics;
|
||||
|
||||
const BAR: *mut i32 = unsafe { intrinsics::const_allocate(4, 4) as *mut i32 };
|
||||
//~^ error: mutable pointer in final value of constant
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
fn main() {}
|
||||
|
||||
@ -1,8 +1,31 @@
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/alloc_intrinsic_untyped.rs:6:1
|
||||
--> $DIR/alloc_intrinsic_untyped.rs:7:1
|
||||
|
|
||||
LL | const BAR: *mut i32 = unsafe { intrinsics::const_allocate(4, 4) as *mut i32 };
|
||||
| ^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/alloc_intrinsic_untyped.rs:4:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: aborting due to 1 previous error
|
||||
|
||||
Future incompatibility report: Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/alloc_intrinsic_untyped.rs:7:1
|
||||
|
|
||||
LL | const BAR: *mut i32 = unsafe { intrinsics::const_allocate(4, 4) as *mut i32 };
|
||||
| ^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/alloc_intrinsic_untyped.rs:4:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
|
||||
@ -0,0 +1,18 @@
|
||||
//@ check-pass
|
||||
use std::cell::Cell;
|
||||
|
||||
pub enum JsValue {
|
||||
Undefined,
|
||||
Object(Cell<bool>),
|
||||
}
|
||||
|
||||
impl ::std::ops::Drop for JsValue {
|
||||
fn drop(&mut self) {}
|
||||
}
|
||||
|
||||
const UNDEFINED: &JsValue = &JsValue::Undefined;
|
||||
//~^ WARN encountered mutable pointer in final value of constant
|
||||
//~| WARN this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
|
||||
fn main() {
|
||||
}
|
||||
@ -0,0 +1,23 @@
|
||||
warning: encountered mutable pointer in final value of constant
|
||||
--> $DIR/future-incompat-mutable-in-final-value-issue-121610.rs:13:1
|
||||
|
|
||||
LL | const UNDEFINED: &JsValue = &JsValue::Undefined;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
= note: `#[warn(const_eval_mutable_ptr_in_final_value)]` on by default
|
||||
|
||||
warning: 1 warning emitted
|
||||
|
||||
Future incompatibility report: Future breakage diagnostic:
|
||||
warning: encountered mutable pointer in final value of constant
|
||||
--> $DIR/future-incompat-mutable-in-final-value-issue-121610.rs:13:1
|
||||
|
|
||||
LL | const UNDEFINED: &JsValue = &JsValue::Undefined;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
= note: `#[warn(const_eval_mutable_ptr_in_final_value)]` on by default
|
||||
|
||||
@ -1,19 +1,25 @@
|
||||
//@ compile-flags: -Zunleash-the-miri-inside-of-you
|
||||
//@ normalize-stderr-test "(the raw bytes of the constant) \(size: [0-9]*, align: [0-9]*\)" -> "$1 (size: $$SIZE, align: $$ALIGN)"
|
||||
//@ normalize-stderr-test "([0-9a-f][0-9a-f] |╾─*ALLOC[0-9]+(\+[a-z0-9]+)?(<imm>)?─*╼ )+ *│.*" -> "HEX_DUMP"
|
||||
|
||||
#![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
use std::cell::UnsafeCell;
|
||||
|
||||
// a test demonstrating what things we could allow with a smarter const qualification
|
||||
|
||||
static FOO: &&mut u32 = &&mut 42;
|
||||
//~^ ERROR encountered mutable pointer in final value of static
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
static BAR: &mut () = &mut ();
|
||||
//~^ ERROR encountered mutable pointer in final value of static
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
struct Foo<T>(T);
|
||||
|
||||
static BOO: &mut Foo<()> = &mut Foo(());
|
||||
//~^ ERROR encountered mutable pointer in final value of static
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
struct Meh {
|
||||
x: &'static UnsafeCell<i32>,
|
||||
@ -21,9 +27,12 @@ struct Meh {
|
||||
unsafe impl Sync for Meh {}
|
||||
static MEH: Meh = Meh { x: &UnsafeCell::new(42) };
|
||||
//~^ ERROR encountered mutable pointer in final value of static
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
static OH_YES: &mut i32 = &mut 42;
|
||||
//~^ ERROR encountered mutable pointer in final value of static
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
//~| ERROR it is undefined behavior to use this value
|
||||
|
||||
fn main() {
|
||||
unsafe {
|
||||
|
||||
@ -1,35 +1,66 @@
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/mutable_references.rs:7:1
|
||||
|
|
||||
LL | static FOO: &&mut u32 = &&mut 42;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/mutable_references.rs:10:1
|
||||
|
|
||||
LL | static BAR: &mut () = &mut ();
|
||||
| ^^^^^^^^^^^^^^^^^^^
|
||||
LL | static FOO: &&mut u32 = &&mut 42;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/mutable_references.rs:15:1
|
||||
--> $DIR/mutable_references.rs:14:1
|
||||
|
|
||||
LL | static BAR: &mut () = &mut ();
|
||||
| ^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/mutable_references.rs:20:1
|
||||
|
|
||||
LL | static BOO: &mut Foo<()> = &mut Foo(());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/mutable_references.rs:22:1
|
||||
--> $DIR/mutable_references.rs:28:1
|
||||
|
|
||||
LL | static MEH: Meh = Meh { x: &UnsafeCell::new(42) };
|
||||
| ^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/mutable_references.rs:25:1
|
||||
--> $DIR/mutable_references.rs:32:1
|
||||
|
|
||||
LL | static OH_YES: &mut i32 = &mut 42;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error[E0080]: it is undefined behavior to use this value
|
||||
--> $DIR/mutable_references.rs:32:1
|
||||
|
|
||||
LL | static OH_YES: &mut i32 = &mut 42;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^ constructing invalid value: encountered mutable reference or box pointing to read-only memory
|
||||
|
|
||||
= note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
|
||||
= note: the raw bytes of the constant (size: $SIZE, align: $ALIGN) {
|
||||
HEX_DUMP
|
||||
}
|
||||
|
||||
error[E0594]: cannot assign to `*OH_YES`, as `OH_YES` is an immutable static item
|
||||
--> $DIR/mutable_references.rs:32:5
|
||||
--> $DIR/mutable_references.rs:41:5
|
||||
|
|
||||
LL | *OH_YES = 99;
|
||||
| ^^^^^^^^^^^^ cannot assign
|
||||
@ -37,31 +68,107 @@ LL | *OH_YES = 99;
|
||||
warning: skipping const checks
|
||||
|
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references.rs:7:26
|
||||
--> $DIR/mutable_references.rs:10:26
|
||||
|
|
||||
LL | static FOO: &&mut u32 = &&mut 42;
|
||||
| ^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references.rs:10:23
|
||||
--> $DIR/mutable_references.rs:14:23
|
||||
|
|
||||
LL | static BAR: &mut () = &mut ();
|
||||
| ^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references.rs:15:28
|
||||
--> $DIR/mutable_references.rs:20:28
|
||||
|
|
||||
LL | static BOO: &mut Foo<()> = &mut Foo(());
|
||||
| ^^^^^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references.rs:22:28
|
||||
--> $DIR/mutable_references.rs:28:28
|
||||
|
|
||||
LL | static MEH: Meh = Meh { x: &UnsafeCell::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references.rs:25:27
|
||||
--> $DIR/mutable_references.rs:32:27
|
||||
|
|
||||
LL | static OH_YES: &mut i32 = &mut 42;
|
||||
| ^^^^^^^
|
||||
|
||||
error: aborting due to 6 previous errors; 1 warning emitted
|
||||
error: aborting due to 7 previous errors; 1 warning emitted
|
||||
|
||||
Some errors have detailed explanations: E0080, E0594.
|
||||
For more information about an error, try `rustc --explain E0080`.
|
||||
Future incompatibility report: Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/mutable_references.rs:10:1
|
||||
|
|
||||
LL | static FOO: &&mut u32 = &&mut 42;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/mutable_references.rs:14:1
|
||||
|
|
||||
LL | static BAR: &mut () = &mut ();
|
||||
| ^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/mutable_references.rs:20:1
|
||||
|
|
||||
LL | static BOO: &mut Foo<()> = &mut Foo(());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/mutable_references.rs:28:1
|
||||
|
|
||||
LL | static MEH: Meh = Meh { x: &UnsafeCell::new(42) };
|
||||
| ^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/mutable_references.rs:32:1
|
||||
|
|
||||
LL | static OH_YES: &mut i32 = &mut 42;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
For more information about this error, try `rustc --explain E0594`.
|
||||
|
||||
@ -2,7 +2,7 @@
|
||||
//@ normalize-stderr-test "(the raw bytes of the constant) \(size: [0-9]*, align: [0-9]*\)" -> "$1 (size: $$SIZE, align: $$ALIGN)"
|
||||
//@ normalize-stderr-test "([0-9a-f][0-9a-f] |╾─*ALLOC[0-9]+(\+[a-z0-9]+)?(<imm>)?─*╼ )+ *│.*" -> "HEX_DUMP"
|
||||
#![allow(invalid_reference_casting, static_mut_refs)]
|
||||
|
||||
#![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
use std::cell::UnsafeCell;
|
||||
use std::sync::atomic::*;
|
||||
|
||||
@ -17,6 +17,8 @@ unsafe impl Sync for Meh {}
|
||||
// all allocs interned here will be marked immutable.
|
||||
const MUH: Meh = Meh {
|
||||
//~^ ERROR encountered mutable pointer in final value of constant
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
//~| ERROR: it is undefined behavior to use this value
|
||||
x: &UnsafeCell::new(42),
|
||||
};
|
||||
|
||||
@ -28,14 +30,19 @@ unsafe impl Sync for Synced {}
|
||||
// Make sure we also catch this behind a type-erased `dyn Trait` reference.
|
||||
const SNEAKY: &dyn Sync = &Synced { x: UnsafeCell::new(42) };
|
||||
//~^ ERROR: mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
//~| ERROR it is undefined behavior to use this value
|
||||
|
||||
// Make sure we also catch mutable references in values that shouldn't have them.
|
||||
static mut FOO: i32 = 0;
|
||||
const SUBTLE: &mut i32 = unsafe { &mut FOO };
|
||||
//~^ ERROR: it is undefined behavior to use this value
|
||||
//~| static
|
||||
|
||||
const BLUNT: &mut i32 = &mut 42;
|
||||
//~^ ERROR: mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
//~| ERROR it is undefined behavior to use this value
|
||||
|
||||
// Check for mutable references to read-only memory.
|
||||
static READONLY: i32 = 0;
|
||||
@ -56,10 +63,15 @@ const POINTS_TO_MUTABLE2: &i32 = unsafe { &*MUTABLE_REF };
|
||||
|
||||
const POINTS_TO_MUTABLE_INNER: *const i32 = &mut 42 as *mut _ as *const _;
|
||||
//~^ ERROR: mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
const POINTS_TO_MUTABLE_INNER2: *const i32 = &mut 42 as *const _;
|
||||
//~^ ERROR: mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
const INTERIOR_MUTABLE_BEHIND_RAW: *mut i32 = &UnsafeCell::new(42) as *const _ as *mut _;
|
||||
//~^ ERROR: mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
struct SyncPtr<T> {
|
||||
x: *const T,
|
||||
@ -72,10 +84,15 @@ unsafe impl<T> Sync for SyncPtr<T> {}
|
||||
// (Also see `static-no-inner-mut` for similar tests on `static`.)
|
||||
const RAW_SYNC: SyncPtr<AtomicI32> = SyncPtr { x: &AtomicI32::new(42) };
|
||||
//~^ ERROR mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
const RAW_MUT_CAST: SyncPtr<i32> = SyncPtr { x: &mut 42 as *mut _ as *const _ };
|
||||
//~^ ERROR mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
const RAW_MUT_COERCE: SyncPtr<i32> = SyncPtr { x: &mut 0 };
|
||||
//~^ ERROR mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
fn main() {
|
||||
unsafe {
|
||||
|
||||
@ -3,15 +3,48 @@ error: encountered mutable pointer in final value of constant
|
||||
|
|
||||
LL | const MUH: Meh = Meh {
|
||||
| ^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references_err.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error[E0080]: it is undefined behavior to use this value
|
||||
--> $DIR/mutable_references_err.rs:18:1
|
||||
|
|
||||
LL | const MUH: Meh = Meh {
|
||||
| ^^^^^^^^^^^^^^ constructing invalid value at .x.<deref>: encountered `UnsafeCell` in read-only memory
|
||||
|
|
||||
= note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
|
||||
= note: the raw bytes of the constant (size: $SIZE, align: $ALIGN) {
|
||||
HEX_DUMP
|
||||
}
|
||||
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:29:1
|
||||
--> $DIR/mutable_references_err.rs:31:1
|
||||
|
|
||||
LL | const SNEAKY: &dyn Sync = &Synced { x: UnsafeCell::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error[E0080]: it is undefined behavior to use this value
|
||||
--> $DIR/mutable_references_err.rs:34:1
|
||||
--> $DIR/mutable_references_err.rs:31:1
|
||||
|
|
||||
LL | const SNEAKY: &dyn Sync = &Synced { x: UnsafeCell::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^ constructing invalid value at .<deref>.<dyn-downcast>.x: encountered `UnsafeCell` in read-only memory
|
||||
|
|
||||
= note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
|
||||
= note: the raw bytes of the constant (size: $SIZE, align: $ALIGN) {
|
||||
HEX_DUMP
|
||||
}
|
||||
|
||||
error[E0080]: it is undefined behavior to use this value
|
||||
--> $DIR/mutable_references_err.rs:38:1
|
||||
|
|
||||
LL | const SUBTLE: &mut i32 = unsafe { &mut FOO };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^ constructing invalid value: encountered reference to mutable memory in `const`
|
||||
@ -22,14 +55,28 @@ LL | const SUBTLE: &mut i32 = unsafe { &mut FOO };
|
||||
}
|
||||
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:37:1
|
||||
--> $DIR/mutable_references_err.rs:42:1
|
||||
|
|
||||
LL | const BLUNT: &mut i32 = &mut 42;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error[E0080]: it is undefined behavior to use this value
|
||||
--> $DIR/mutable_references_err.rs:42:1
|
||||
|
|
||||
LL | const BLUNT: &mut i32 = &mut 42;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^ constructing invalid value: encountered mutable reference or box pointing to read-only memory
|
||||
|
|
||||
= note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
|
||||
= note: the raw bytes of the constant (size: $SIZE, align: $ALIGN) {
|
||||
HEX_DUMP
|
||||
}
|
||||
|
||||
error[E0080]: it is undefined behavior to use this value
|
||||
--> $DIR/mutable_references_err.rs:49:1
|
||||
|
|
||||
LL | static mut MUT_TO_READONLY: &mut i32 = unsafe { &mut *(&READONLY as *const _ as *mut _) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ constructing invalid value: encountered mutable reference or box pointing to read-only memory
|
||||
|
|
||||
@ -39,7 +86,7 @@ LL | static mut MUT_TO_READONLY: &mut i32 = unsafe { &mut *(&READONLY as *const
|
||||
}
|
||||
|
||||
error[E0080]: it is undefined behavior to use this value
|
||||
--> $DIR/mutable_references_err.rs:49:1
|
||||
--> $DIR/mutable_references_err.rs:56:1
|
||||
|
|
||||
LL | const POINTS_TO_MUTABLE1: &i32 = unsafe { &MUTABLE };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ constructing invalid value: encountered reference to mutable memory in `const`
|
||||
@ -50,131 +97,284 @@ LL | const POINTS_TO_MUTABLE1: &i32 = unsafe { &MUTABLE };
|
||||
}
|
||||
|
||||
note: erroneous constant encountered
|
||||
--> $DIR/mutable_references_err.rs:51:34
|
||||
--> $DIR/mutable_references_err.rs:58:34
|
||||
|
|
||||
LL | const READS_FROM_MUTABLE: i32 = *POINTS_TO_MUTABLE1;
|
||||
| ^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error[E0080]: evaluation of constant value failed
|
||||
--> $DIR/mutable_references_err.rs:53:43
|
||||
--> $DIR/mutable_references_err.rs:60:43
|
||||
|
|
||||
LL | const POINTS_TO_MUTABLE2: &i32 = unsafe { &*MUTABLE_REF };
|
||||
| ^^^^^^^^^^^^^ constant accesses mutable global memory
|
||||
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:57:1
|
||||
--> $DIR/mutable_references_err.rs:64:1
|
||||
|
|
||||
LL | const POINTS_TO_MUTABLE_INNER: *const i32 = &mut 42 as *mut _ as *const _;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:59:1
|
||||
--> $DIR/mutable_references_err.rs:68:1
|
||||
|
|
||||
LL | const POINTS_TO_MUTABLE_INNER2: *const i32 = &mut 42 as *const _;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:61:1
|
||||
--> $DIR/mutable_references_err.rs:72:1
|
||||
|
|
||||
LL | const INTERIOR_MUTABLE_BEHIND_RAW: *mut i32 = &UnsafeCell::new(42) as *const _ as *mut _;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:73:1
|
||||
--> $DIR/mutable_references_err.rs:85:1
|
||||
|
|
||||
LL | const RAW_SYNC: SyncPtr<AtomicI32> = SyncPtr { x: &AtomicI32::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:75:1
|
||||
--> $DIR/mutable_references_err.rs:89:1
|
||||
|
|
||||
LL | const RAW_MUT_CAST: SyncPtr<i32> = SyncPtr { x: &mut 42 as *mut _ as *const _ };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:77:1
|
||||
--> $DIR/mutable_references_err.rs:93:1
|
||||
|
|
||||
LL | const RAW_MUT_COERCE: SyncPtr<i32> = SyncPtr { x: &mut 0 };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
warning: skipping const checks
|
||||
|
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references_err.rs:20:8
|
||||
--> $DIR/mutable_references_err.rs:22:8
|
||||
|
|
||||
LL | x: &UnsafeCell::new(42),
|
||||
| ^^^^^^^^^^^^^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references_err.rs:29:27
|
||||
--> $DIR/mutable_references_err.rs:31:27
|
||||
|
|
||||
LL | const SNEAKY: &dyn Sync = &Synced { x: UnsafeCell::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
help: skipping check for `const_refs_to_static` feature
|
||||
--> $DIR/mutable_references_err.rs:34:40
|
||||
--> $DIR/mutable_references_err.rs:38:40
|
||||
|
|
||||
LL | const SUBTLE: &mut i32 = unsafe { &mut FOO };
|
||||
| ^^^
|
||||
help: skipping check for `const_mut_refs` feature
|
||||
--> $DIR/mutable_references_err.rs:34:35
|
||||
--> $DIR/mutable_references_err.rs:38:35
|
||||
|
|
||||
LL | const SUBTLE: &mut i32 = unsafe { &mut FOO };
|
||||
| ^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references_err.rs:37:25
|
||||
--> $DIR/mutable_references_err.rs:42:25
|
||||
|
|
||||
LL | const BLUNT: &mut i32 = &mut 42;
|
||||
| ^^^^^^^
|
||||
help: skipping check for `const_mut_refs` feature
|
||||
--> $DIR/mutable_references_err.rs:42:49
|
||||
--> $DIR/mutable_references_err.rs:49:49
|
||||
|
|
||||
LL | static mut MUT_TO_READONLY: &mut i32 = unsafe { &mut *(&READONLY as *const _ as *mut _) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
help: skipping check for `const_mut_refs` feature
|
||||
--> $DIR/mutable_references_err.rs:42:49
|
||||
--> $DIR/mutable_references_err.rs:49:49
|
||||
|
|
||||
LL | static mut MUT_TO_READONLY: &mut i32 = unsafe { &mut *(&READONLY as *const _ as *mut _) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
help: skipping check for `const_refs_to_static` feature
|
||||
--> $DIR/mutable_references_err.rs:49:44
|
||||
--> $DIR/mutable_references_err.rs:56:44
|
||||
|
|
||||
LL | const POINTS_TO_MUTABLE1: &i32 = unsafe { &MUTABLE };
|
||||
| ^^^^^^^
|
||||
help: skipping check for `const_refs_to_static` feature
|
||||
--> $DIR/mutable_references_err.rs:53:45
|
||||
--> $DIR/mutable_references_err.rs:60:45
|
||||
|
|
||||
LL | const POINTS_TO_MUTABLE2: &i32 = unsafe { &*MUTABLE_REF };
|
||||
| ^^^^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references_err.rs:57:45
|
||||
--> $DIR/mutable_references_err.rs:64:45
|
||||
|
|
||||
LL | const POINTS_TO_MUTABLE_INNER: *const i32 = &mut 42 as *mut _ as *const _;
|
||||
| ^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references_err.rs:59:46
|
||||
--> $DIR/mutable_references_err.rs:68:46
|
||||
|
|
||||
LL | const POINTS_TO_MUTABLE_INNER2: *const i32 = &mut 42 as *const _;
|
||||
| ^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references_err.rs:61:47
|
||||
--> $DIR/mutable_references_err.rs:72:47
|
||||
|
|
||||
LL | const INTERIOR_MUTABLE_BEHIND_RAW: *mut i32 = &UnsafeCell::new(42) as *const _ as *mut _;
|
||||
| ^^^^^^^^^^^^^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references_err.rs:73:51
|
||||
--> $DIR/mutable_references_err.rs:85:51
|
||||
|
|
||||
LL | const RAW_SYNC: SyncPtr<AtomicI32> = SyncPtr { x: &AtomicI32::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references_err.rs:75:49
|
||||
--> $DIR/mutable_references_err.rs:89:49
|
||||
|
|
||||
LL | const RAW_MUT_CAST: SyncPtr<i32> = SyncPtr { x: &mut 42 as *mut _ as *const _ };
|
||||
| ^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/mutable_references_err.rs:77:51
|
||||
--> $DIR/mutable_references_err.rs:93:51
|
||||
|
|
||||
LL | const RAW_MUT_COERCE: SyncPtr<i32> = SyncPtr { x: &mut 0 };
|
||||
| ^^^^^^
|
||||
|
||||
error: aborting due to 13 previous errors; 1 warning emitted
|
||||
error: aborting due to 16 previous errors; 1 warning emitted
|
||||
|
||||
For more information about this error, try `rustc --explain E0080`.
|
||||
Future incompatibility report: Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:18:1
|
||||
|
|
||||
LL | const MUH: Meh = Meh {
|
||||
| ^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references_err.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:31:1
|
||||
|
|
||||
LL | const SNEAKY: &dyn Sync = &Synced { x: UnsafeCell::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references_err.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:42:1
|
||||
|
|
||||
LL | const BLUNT: &mut i32 = &mut 42;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references_err.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:64:1
|
||||
|
|
||||
LL | const POINTS_TO_MUTABLE_INNER: *const i32 = &mut 42 as *mut _ as *const _;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references_err.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:68:1
|
||||
|
|
||||
LL | const POINTS_TO_MUTABLE_INNER2: *const i32 = &mut 42 as *const _;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references_err.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:72:1
|
||||
|
|
||||
LL | const INTERIOR_MUTABLE_BEHIND_RAW: *mut i32 = &UnsafeCell::new(42) as *const _ as *mut _;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references_err.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:85:1
|
||||
|
|
||||
LL | const RAW_SYNC: SyncPtr<AtomicI32> = SyncPtr { x: &AtomicI32::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references_err.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:89:1
|
||||
|
|
||||
LL | const RAW_MUT_CAST: SyncPtr<i32> = SyncPtr { x: &mut 42 as *mut _ as *const _ };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references_err.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of constant
|
||||
--> $DIR/mutable_references_err.rs:93:1
|
||||
|
|
||||
LL | const RAW_MUT_COERCE: SyncPtr<i32> = SyncPtr { x: &mut 0 };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/mutable_references_err.rs:5:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
|
||||
@ -3,42 +3,90 @@ error: encountered mutable pointer in final value of static
|
||||
|
|
||||
LL | static REF: &AtomicI32 = &AtomicI32::new(42);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:10:1
|
||||
|
|
||||
LL | static REFMUT: &mut i32 = &mut 0;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:13:1
|
||||
|
|
||||
LL | static REF2: &AtomicI32 = {let x = AtomicI32::new(42); &{x}};
|
||||
LL | static REFMUT: &mut i32 = &mut 0;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error[E0080]: it is undefined behavior to use this value
|
||||
--> $DIR/static-no-inner-mut.rs:13:1
|
||||
|
|
||||
LL | static REFMUT: &mut i32 = &mut 0;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^ constructing invalid value: encountered mutable reference or box pointing to read-only memory
|
||||
|
|
||||
= note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
|
||||
= note: the raw bytes of the constant (size: 4, align: 4) {
|
||||
╾ALLOC0╼ │ ╾──╼
|
||||
}
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:14:1
|
||||
--> $DIR/static-no-inner-mut.rs:19:1
|
||||
|
|
||||
LL | static REF2: &AtomicI32 = {let x = AtomicI32::new(42); &{x}};
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:23:1
|
||||
|
|
||||
LL | static REFMUT2: &mut i32 = {let mut x = 0; &mut {x}};
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error[E0080]: it is undefined behavior to use this value
|
||||
--> $DIR/static-no-inner-mut.rs:23:1
|
||||
|
|
||||
LL | static REFMUT2: &mut i32 = {let mut x = 0; &mut {x}};
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^ constructing invalid value: encountered mutable reference or box pointing to read-only memory
|
||||
|
|
||||
= note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
|
||||
= note: the raw bytes of the constant (size: 4, align: 4) {
|
||||
╾ALLOC1╼ │ ╾──╼
|
||||
}
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:29:1
|
||||
--> $DIR/static-no-inner-mut.rs:41:1
|
||||
|
|
||||
LL | static RAW_SYNC: SyncPtr<AtomicI32> = SyncPtr { x: &AtomicI32::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:31:1
|
||||
--> $DIR/static-no-inner-mut.rs:45:1
|
||||
|
|
||||
LL | static RAW_MUT_CAST: SyncPtr<i32> = SyncPtr { x : &mut 42 as *mut _ as *const _ };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:33:1
|
||||
--> $DIR/static-no-inner-mut.rs:49:1
|
||||
|
|
||||
LL | static RAW_MUT_COERCE: SyncPtr<i32> = SyncPtr { x: &mut 0 };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
warning: skipping const checks
|
||||
|
|
||||
@ -48,35 +96,141 @@ help: skipping check that does not even have a feature gate
|
||||
LL | static REF: &AtomicI32 = &AtomicI32::new(42);
|
||||
| ^^^^^^^^^^^^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/static-no-inner-mut.rs:10:27
|
||||
--> $DIR/static-no-inner-mut.rs:13:27
|
||||
|
|
||||
LL | static REFMUT: &mut i32 = &mut 0;
|
||||
| ^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/static-no-inner-mut.rs:13:56
|
||||
--> $DIR/static-no-inner-mut.rs:19:56
|
||||
|
|
||||
LL | static REF2: &AtomicI32 = {let x = AtomicI32::new(42); &{x}};
|
||||
| ^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/static-no-inner-mut.rs:14:44
|
||||
--> $DIR/static-no-inner-mut.rs:23:44
|
||||
|
|
||||
LL | static REFMUT2: &mut i32 = {let mut x = 0; &mut {x}};
|
||||
| ^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/static-no-inner-mut.rs:29:52
|
||||
--> $DIR/static-no-inner-mut.rs:41:52
|
||||
|
|
||||
LL | static RAW_SYNC: SyncPtr<AtomicI32> = SyncPtr { x: &AtomicI32::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/static-no-inner-mut.rs:31:51
|
||||
--> $DIR/static-no-inner-mut.rs:45:51
|
||||
|
|
||||
LL | static RAW_MUT_CAST: SyncPtr<i32> = SyncPtr { x : &mut 42 as *mut _ as *const _ };
|
||||
| ^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/static-no-inner-mut.rs:33:52
|
||||
--> $DIR/static-no-inner-mut.rs:49:52
|
||||
|
|
||||
LL | static RAW_MUT_COERCE: SyncPtr<i32> = SyncPtr { x: &mut 0 };
|
||||
| ^^^^^^
|
||||
|
||||
error: aborting due to 7 previous errors; 1 warning emitted
|
||||
error: aborting due to 9 previous errors; 1 warning emitted
|
||||
|
||||
For more information about this error, try `rustc --explain E0080`.
|
||||
Future incompatibility report: Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:9:1
|
||||
|
|
||||
LL | static REF: &AtomicI32 = &AtomicI32::new(42);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:13:1
|
||||
|
|
||||
LL | static REFMUT: &mut i32 = &mut 0;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:19:1
|
||||
|
|
||||
LL | static REF2: &AtomicI32 = {let x = AtomicI32::new(42); &{x}};
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:23:1
|
||||
|
|
||||
LL | static REFMUT2: &mut i32 = {let mut x = 0; &mut {x}};
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:41:1
|
||||
|
|
||||
LL | static RAW_SYNC: SyncPtr<AtomicI32> = SyncPtr { x: &AtomicI32::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:45:1
|
||||
|
|
||||
LL | static RAW_MUT_CAST: SyncPtr<i32> = SyncPtr { x : &mut 42 as *mut _ as *const _ };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:49:1
|
||||
|
|
||||
LL | static RAW_MUT_COERCE: SyncPtr<i32> = SyncPtr { x: &mut 0 };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
|
||||
@ -3,42 +3,90 @@ error: encountered mutable pointer in final value of static
|
||||
|
|
||||
LL | static REF: &AtomicI32 = &AtomicI32::new(42);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:10:1
|
||||
|
|
||||
LL | static REFMUT: &mut i32 = &mut 0;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:13:1
|
||||
|
|
||||
LL | static REF2: &AtomicI32 = {let x = AtomicI32::new(42); &{x}};
|
||||
LL | static REFMUT: &mut i32 = &mut 0;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error[E0080]: it is undefined behavior to use this value
|
||||
--> $DIR/static-no-inner-mut.rs:13:1
|
||||
|
|
||||
LL | static REFMUT: &mut i32 = &mut 0;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^ constructing invalid value: encountered mutable reference or box pointing to read-only memory
|
||||
|
|
||||
= note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
|
||||
= note: the raw bytes of the constant (size: 8, align: 8) {
|
||||
╾ALLOC0╼ │ ╾──────╼
|
||||
}
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:14:1
|
||||
--> $DIR/static-no-inner-mut.rs:19:1
|
||||
|
|
||||
LL | static REF2: &AtomicI32 = {let x = AtomicI32::new(42); &{x}};
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:23:1
|
||||
|
|
||||
LL | static REFMUT2: &mut i32 = {let mut x = 0; &mut {x}};
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error[E0080]: it is undefined behavior to use this value
|
||||
--> $DIR/static-no-inner-mut.rs:23:1
|
||||
|
|
||||
LL | static REFMUT2: &mut i32 = {let mut x = 0; &mut {x}};
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^ constructing invalid value: encountered mutable reference or box pointing to read-only memory
|
||||
|
|
||||
= note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
|
||||
= note: the raw bytes of the constant (size: 8, align: 8) {
|
||||
╾ALLOC1╼ │ ╾──────╼
|
||||
}
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:29:1
|
||||
--> $DIR/static-no-inner-mut.rs:41:1
|
||||
|
|
||||
LL | static RAW_SYNC: SyncPtr<AtomicI32> = SyncPtr { x: &AtomicI32::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:31:1
|
||||
--> $DIR/static-no-inner-mut.rs:45:1
|
||||
|
|
||||
LL | static RAW_MUT_CAST: SyncPtr<i32> = SyncPtr { x : &mut 42 as *mut _ as *const _ };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:33:1
|
||||
--> $DIR/static-no-inner-mut.rs:49:1
|
||||
|
|
||||
LL | static RAW_MUT_COERCE: SyncPtr<i32> = SyncPtr { x: &mut 0 };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
|
||||
warning: skipping const checks
|
||||
|
|
||||
@ -48,35 +96,141 @@ help: skipping check that does not even have a feature gate
|
||||
LL | static REF: &AtomicI32 = &AtomicI32::new(42);
|
||||
| ^^^^^^^^^^^^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/static-no-inner-mut.rs:10:27
|
||||
--> $DIR/static-no-inner-mut.rs:13:27
|
||||
|
|
||||
LL | static REFMUT: &mut i32 = &mut 0;
|
||||
| ^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/static-no-inner-mut.rs:13:56
|
||||
--> $DIR/static-no-inner-mut.rs:19:56
|
||||
|
|
||||
LL | static REF2: &AtomicI32 = {let x = AtomicI32::new(42); &{x}};
|
||||
| ^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/static-no-inner-mut.rs:14:44
|
||||
--> $DIR/static-no-inner-mut.rs:23:44
|
||||
|
|
||||
LL | static REFMUT2: &mut i32 = {let mut x = 0; &mut {x}};
|
||||
| ^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/static-no-inner-mut.rs:29:52
|
||||
--> $DIR/static-no-inner-mut.rs:41:52
|
||||
|
|
||||
LL | static RAW_SYNC: SyncPtr<AtomicI32> = SyncPtr { x: &AtomicI32::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/static-no-inner-mut.rs:31:51
|
||||
--> $DIR/static-no-inner-mut.rs:45:51
|
||||
|
|
||||
LL | static RAW_MUT_CAST: SyncPtr<i32> = SyncPtr { x : &mut 42 as *mut _ as *const _ };
|
||||
| ^^^^^^^
|
||||
help: skipping check that does not even have a feature gate
|
||||
--> $DIR/static-no-inner-mut.rs:33:52
|
||||
--> $DIR/static-no-inner-mut.rs:49:52
|
||||
|
|
||||
LL | static RAW_MUT_COERCE: SyncPtr<i32> = SyncPtr { x: &mut 0 };
|
||||
| ^^^^^^
|
||||
|
||||
error: aborting due to 7 previous errors; 1 warning emitted
|
||||
error: aborting due to 9 previous errors; 1 warning emitted
|
||||
|
||||
For more information about this error, try `rustc --explain E0080`.
|
||||
Future incompatibility report: Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:9:1
|
||||
|
|
||||
LL | static REF: &AtomicI32 = &AtomicI32::new(42);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:13:1
|
||||
|
|
||||
LL | static REFMUT: &mut i32 = &mut 0;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:19:1
|
||||
|
|
||||
LL | static REF2: &AtomicI32 = {let x = AtomicI32::new(42); &{x}};
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:23:1
|
||||
|
|
||||
LL | static REFMUT2: &mut i32 = {let mut x = 0; &mut {x}};
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:41:1
|
||||
|
|
||||
LL | static RAW_SYNC: SyncPtr<AtomicI32> = SyncPtr { x: &AtomicI32::new(42) };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:45:1
|
||||
|
|
||||
LL | static RAW_MUT_CAST: SyncPtr<i32> = SyncPtr { x : &mut 42 as *mut _ as *const _ };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
Future breakage diagnostic:
|
||||
error: encountered mutable pointer in final value of static
|
||||
--> $DIR/static-no-inner-mut.rs:49:1
|
||||
|
|
||||
LL | static RAW_MUT_COERCE: SyncPtr<i32> = SyncPtr { x: &mut 0 };
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
note: the lint level is defined here
|
||||
--> $DIR/static-no-inner-mut.rs:6:9
|
||||
|
|
||||
LL | #![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
|
||||
@ -3,15 +3,27 @@
|
||||
#![feature(const_refs_to_cell, const_mut_refs)]
|
||||
// All "inner" allocations that come with a `static` are interned immutably. This means it is
|
||||
// crucial that we do not accept any form of (interior) mutability there.
|
||||
|
||||
#![deny(const_eval_mutable_ptr_in_final_value)]
|
||||
use std::sync::atomic::*;
|
||||
|
||||
static REF: &AtomicI32 = &AtomicI32::new(42); //~ERROR mutable pointer in final value
|
||||
static REFMUT: &mut i32 = &mut 0; //~ERROR mutable pointer in final value
|
||||
static REF: &AtomicI32 = &AtomicI32::new(42);
|
||||
//~^ ERROR mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
static REFMUT: &mut i32 = &mut 0;
|
||||
//~^ ERROR mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
//~| ERROR it is undefined behavior to use this value
|
||||
|
||||
// Different way of writing this that avoids promotion.
|
||||
static REF2: &AtomicI32 = {let x = AtomicI32::new(42); &{x}}; //~ERROR mutable pointer in final value
|
||||
static REFMUT2: &mut i32 = {let mut x = 0; &mut {x}}; //~ERROR mutable pointer in final value
|
||||
static REF2: &AtomicI32 = {let x = AtomicI32::new(42); &{x}};
|
||||
//~^ ERROR mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
static REFMUT2: &mut i32 = {let mut x = 0; &mut {x}};
|
||||
//~^ ERROR mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
//~| ERROR it is undefined behavior to use this value
|
||||
|
||||
// This one is obvious, since it is non-Sync. (It also suppresses the other errors, so it is
|
||||
// commented out.)
|
||||
@ -28,9 +40,14 @@ unsafe impl<T> Sync for SyncPtr<T> {}
|
||||
// non-dangling raw pointers.
|
||||
static RAW_SYNC: SyncPtr<AtomicI32> = SyncPtr { x: &AtomicI32::new(42) };
|
||||
//~^ ERROR mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
static RAW_MUT_CAST: SyncPtr<i32> = SyncPtr { x : &mut 42 as *mut _ as *const _ };
|
||||
//~^ ERROR mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
static RAW_MUT_COERCE: SyncPtr<i32> = SyncPtr { x: &mut 0 };
|
||||
//~^ ERROR mutable pointer in final value
|
||||
//~| WARNING this was previously accepted by the compiler
|
||||
|
||||
fn main() {}
|
||||
|
||||
@ -28,7 +28,8 @@ impl Drop for JsValue {
|
||||
fn drop(&mut self) {}
|
||||
}
|
||||
const UNDEFINED: &JsValue = &JsValue::Undefined;
|
||||
//~^ERROR: mutable pointer in final value of constant
|
||||
//~^ WARNING: mutable pointer in final value of constant
|
||||
//~| WARNING: this was previously accepted by the compiler but is being phased out
|
||||
|
||||
// In contrast, this one works since it is being promoted.
|
||||
const NONE: &'static Option<Cell<i32>> = &None;
|
||||
|
||||
@ -12,12 +12,27 @@ error[E0492]: constants cannot refer to interior mutable data
|
||||
LL | const RAW_SYNC_C: SyncPtr<Cell<i32>> = SyncPtr { x: &Cell::new(42) };
|
||||
| ^^^^^^^^^^^^^^ this borrow of an interior mutable value may end up in the final value
|
||||
|
||||
error: encountered mutable pointer in final value of constant
|
||||
warning: encountered mutable pointer in final value of constant
|
||||
--> $DIR/refs-to-cell-in-final.rs:30:1
|
||||
|
|
||||
LL | const UNDEFINED: &JsValue = &JsValue::Undefined;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
= note: `#[warn(const_eval_mutable_ptr_in_final_value)]` on by default
|
||||
|
||||
error: aborting due to 3 previous errors
|
||||
error: aborting due to 2 previous errors; 1 warning emitted
|
||||
|
||||
For more information about this error, try `rustc --explain E0492`.
|
||||
Future incompatibility report: Future breakage diagnostic:
|
||||
warning: encountered mutable pointer in final value of constant
|
||||
--> $DIR/refs-to-cell-in-final.rs:30:1
|
||||
|
|
||||
LL | const UNDEFINED: &JsValue = &JsValue::Undefined;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
||||
= note: for more information, see issue #122153 <https://github.com/rust-lang/rust/issues/122153>
|
||||
= note: `#[warn(const_eval_mutable_ptr_in_final_value)]` on by default
|
||||
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user