mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto merge of #15159 - tetsuharuohzeki:enable-noImplicitOverride, r=Veykril

Browse Source 
editor/code: Enable `noImplicitOverride` ts option

This enables TypeScript's [`--noImplicitOverride`](https://www.typescriptlang.org/tsconfig#noImplicitOverride) option.
This commit is contained in:
bors 2023-06-28 08:46:38 +00:00
commit c10c6b4029
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
editors/code/src/dependencies_provider.ts
View File

@ -108,10 +108,10 @@ export class RustDependenciesProvider
export class Dependency extends vscode.TreeItem {
constructor(
public readonly label: string,
public override readonly label: string,
private version: string,
readonly dependencyPath: string,
public readonly collapsibleState: vscode.TreeItemCollapsibleState
public override readonly collapsibleState: vscode.TreeItemCollapsibleState
) {
super(label, collapsibleState);
this.resourceUri = vscode.Uri.file(dependencyPath);
@ -127,10 +127,10 @@ export class Dependency extends vscode.TreeItem {
export class DependencyFile extends vscode.TreeItem {
constructor(
readonly label: string,
override readonly label: string,
readonly dependencyPath: string,
readonly parent: Dependency | DependencyFile,
public readonly collapsibleState: vscode.TreeItemCollapsibleState
public override readonly collapsibleState: vscode.TreeItemCollapsibleState
) {
super(vscode.Uri.file(dependencyPath), collapsibleState);
this.id = this.resourceUri!.fsPath.toLowerCase();

1
editors/code/tsconfig.json
View File

@ -13,7 +13,6 @@
// to update typescript version without any code change.
"useUnknownInCatchVariables": false,
"exactOptionalPropertyTypes": false,
"noImplicitOverride": false,
"noPropertyAccessFromIndexSignature": false,
"noUncheckedIndexedAccess": false
},