mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace some std::iter::repeat with str::repeat

Browse Source
This commit is contained in:
r00ster91 2021-06-04 14:32:47 +02:00
parent 6f5a198ffc
commit c08ea1724b
4 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
compiler/rustc_typeck/src/check/mod.rs
View File

@ -858,7 +858,7 @@ fn missing_items_err(
// Obtain the level of indentation ending in `sugg_sp`. // Obtain the level of indentation ending in `sugg_sp`.
let indentation = tcx.sess.source_map().span_to_margin(sugg_sp).unwrap_or(0); let indentation = tcx.sess.source_map().span_to_margin(sugg_sp).unwrap_or(0);
// Make the whitespace that will make the suggestion have the right indentation. // Make the whitespace that will make the suggestion have the right indentation.
let padding: String = std::iter::repeat(" ").take(indentation).collect(); let padding: String = " ".repeat(indentation);
for trait_item in missing_items { for trait_item in missing_items {
let snippet = suggestion_signature(&trait_item, tcx); let snippet = suggestion_signature(&trait_item, tcx);

4
src/test/ui/issues/issue-20644.rs
View File

@ -19,9 +19,7 @@
pub fn parse_summary<R: Read>(_: R, _: &Path) { pub fn parse_summary<R: Read>(_: R, _: &Path) {
let path_from_root = Path::new(""); let path_from_root = Path::new("");
Path::new(&iter::repeat("../") Path::new(&"../".repeat(path_from_root.components().count() - 1));
.take(path_from_root.components().count() - 1)
.collect::<String>());
} }
fn foo() { fn foo() {

3
src/tools/clippy/clippy_lints/src/mem_discriminant.rs
View File

@ -7,7 +7,6 @@
use rustc_hir::{BorrowKind, Expr, ExprKind}; use rustc_hir::{BorrowKind, Expr, ExprKind};
use rustc_lint::{LateContext, LateLintPass}; use rustc_lint::{LateContext, LateLintPass};
use rustc_session::{declare_lint_pass, declare_tool_lint}; use rustc_session::{declare_lint_pass, declare_tool_lint};
use std::iter;
declare_clippy_lint! { declare_clippy_lint! {
/// **What it does:** Checks for calls of `mem::discriminant()` on a non-enum type. /// **What it does:** Checks for calls of `mem::discriminant()` on a non-enum type.
@ -67,7 +66,7 @@ fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
} }
} }
let derefs: String = iter::repeat('*').take(derefs_needed).collect(); let derefs = "*".repeat(derefs_needed);
diag.span_suggestion( diag.span_suggestion(
param.span, param.span,
"try dereferencing", "try dereferencing",

5
src/tools/clippy/clippy_lints/src/methods/clone_on_copy.rs
View File

@ -8,7 +8,6 @@
use rustc_lint::LateContext; use rustc_lint::LateContext;
use rustc_middle::ty::{self, adjustment::Adjust}; use rustc_middle::ty::{self, adjustment::Adjust};
use rustc_span::symbol::{sym, Symbol}; use rustc_span::symbol::{sym, Symbol};
use std::iter;
use super::CLONE_DOUBLE_REF; use super::CLONE_DOUBLE_REF;
use super::CLONE_ON_COPY; use super::CLONE_ON_COPY;
@ -54,8 +53,8 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &Expr<'_>, method_name: Symbol,
ty = inner; ty = inner;
n += 1; n += 1;
} }
let refs: String = iter::repeat('&').take(n + 1).collect(); let refs = "&".repeat(n + 1);
let derefs: String = iter::repeat('*').take(n).collect(); let derefs = "*".repeat(n);
let explicit = format!("<{}{}>::clone({})", refs, ty, snip); let explicit = format!("<{}{}>::clone({})", refs, ty, snip);
diag.span_suggestion( diag.span_suggestion(
expr.span, expr.span,