From bd90868b3f7458fa00dbd6b12927153f28556467 Mon Sep 17 00:00:00 2001 From: Michael Howell Date: Tue, 9 May 2023 13:27:51 -0700 Subject: [PATCH] Use De Morgan's law to simplify logic Co-authored-by: Camille Gillot --- compiler/rustc_middle/src/ty/util.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/compiler/rustc_middle/src/ty/util.rs b/compiler/rustc_middle/src/ty/util.rs index 06f9d32858c..4820d4d2c77 100644 --- a/compiler/rustc_middle/src/ty/util.rs +++ b/compiler/rustc_middle/src/ty/util.rs @@ -867,15 +867,15 @@ impl<'tcx> TyCtxt<'tcx> { pub fn is_user_visible_dep(self, key: CrateNum) -> bool { // | Private | Direct | Visible | | // |---------|--------|---------|--------------------| - // | Yes | Yes | Yes | !(true && !true) | - // | No | Yes | Yes | !(false && !true) | - // | Yes | No | No | !(true && !false) | - // | No | No | Yes | !(false && !false) | - !(self.is_private_dep(key) + // | Yes | Yes | Yes | !true || true | + // | No | Yes | Yes | !false || true | + // | Yes | No | No | !true || false | + // | No | No | Yes | !false || false | + !self.is_private_dep(key) // If `extern_crate` is `None`, then the crate was injected (e.g., by the allocator). // Treat that kind of crate as "indirect", since it's an implementation detail of // the language. - && !self.extern_crate(key.as_def_id()).map_or(false, |e| e.is_direct())) + || self.extern_crate(key.as_def_id()).map_or(false, |e| e.is_direct()) } }