mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary allocation

Browse Source 
The case-insensitive prefix/suffix check can be performed
character-by-character. This allows the check to be done without having
to allocate a new string. As a side effect, it's also no longer
necessary to convert the entire string to lowercase, as it's done as
needed. As the only case equality we're handling is ASCII, this
operation can be further optimized by using byte equality, rather than
character equality.
This commit is contained in:
Jacob Pratt 2021-01-09 21:36:38 -05:00
parent bcb9ae18de
commit bd8a903548
No known key found for this signature in database
GPG Key ID: B80E19E4662B5AA4
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
crates/ide/src/inlay_hints.rs
View File

@ -353,13 +353,18 @@ fn is_argument_similar_to_param_name(
}
match get_string_representation(argument) {
None => false,
Some(mut repr) => {
let param_name = param_name.to_ascii_lowercase();
let argument_string = {
repr.make_ascii_lowercase();
repr.trim_start_matches('_')
};
argument_string.starts_with(&param_name) || argument_string.ends_with(&param_name)
Some(argument_string) => {
let mut arg_bytes = argument_string.bytes().skip_while(|&c| c == b'_');
let starts_with_pattern = param_name.bytes().all(
|expected| matches!(arg_bytes.next(), Some(actual) if expected.eq_ignore_ascii_case(&actual)),
);
let mut arg_bytes = argument_string.bytes();
let ends_with_pattern = param_name.bytes().rev().all(
|expected| matches!(arg_bytes.next_back(), Some(actual) if expected.eq_ignore_ascii_case(&actual)),
);
starts_with_pattern || ends_with_pattern
}
}
}