Suggest importing the right kind of macro.

This commit is contained in:
Mara Bos 2021-08-22 14:06:45 +02:00
parent e7f7fe462a
commit bcc5ecb969
4 changed files with 53 additions and 3 deletions

View File

@ -950,9 +950,7 @@ fn lookup_import_candidates_from_module<FilterFn>(
self.add_typo_suggestion(err, suggestion, ident.span);
let import_suggestions =
self.lookup_import_candidates(ident, Namespace::MacroNS, parent_scope, |res| {
matches!(res, Res::Def(DefKind::Macro(MacroKind::Bang), _))
});
self.lookup_import_candidates(ident, Namespace::MacroNS, parent_scope, is_expected);
show_candidates(err, None, &import_suggestions, false, true);
if macro_kind == MacroKind::Derive && (ident.name == sym::Send || ident.name == sym::Sync) {

View File

@ -0,0 +1,22 @@
// compile-flags: -Z deduplicate-diagnostics=yes
// edition:2018
mod hey {
pub use Copy as Bla;
pub use std::println as bla;
}
#[derive(Bla)]
//~^ ERROR cannot find derive macro `Bla`
//~| NOTE consider importing this derive macro
struct A;
#[derive(println)]
//~^ ERROR cannot find derive macro `println`
struct B;
fn main() {
bla!();
//~^ ERROR cannot find macro `bla`
//~| NOTE consider importing this macro
}

View File

@ -0,0 +1,26 @@
error: cannot find macro `bla` in this scope
--> $DIR/issue-88228.rs:19:5
|
LL | bla!();
| ^^^
|
= note: consider importing this macro:
crate::hey::bla
error: cannot find derive macro `println` in this scope
--> $DIR/issue-88228.rs:14:10
|
LL | #[derive(println)]
| ^^^^^^^
error: cannot find derive macro `Bla` in this scope
--> $DIR/issue-88228.rs:9:10
|
LL | #[derive(Bla)]
| ^^^
|
= note: consider importing this derive macro:
crate::hey::Bla
error: aborting due to 3 previous errors

View File

@ -16,6 +16,8 @@ error: cannot find attribute `empty_helper` in this scope
LL | #[derive(GenHelperUse)]
| ^^^^^^^^^^^^
|
= note: consider importing this attribute macro:
empty_helper
= note: this error originates in the derive macro `GenHelperUse` (in Nightly builds, run with -Z macro-backtrace for more info)
error: cannot find attribute `empty_helper` in this scope
@ -27,6 +29,8 @@ LL | #[empty_helper]
LL | gen_helper_use!();
| ------------------ in this macro invocation
|
= note: consider importing this attribute macro:
crate::empty_helper
= note: this error originates in the macro `gen_helper_use` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0659]: `empty_helper` is ambiguous (name vs any other name during import resolution)