From ba72d9722caf48ad5f184d4da61117f80d98761e Mon Sep 17 00:00:00 2001 From: Richard Diamond Date: Sun, 6 Sep 2015 19:26:41 -0500 Subject: [PATCH] Don't add unnamed address attributes to intrinsics. Intrinsics never have an address, so it doesn't make sense to say that their address is unnamed. --- src/librustc_trans/trans/context.rs | 2 ++ src/test/codegen/intrinsic-no-unnamed-attr.rs | 22 +++++++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 src/test/codegen/intrinsic-no-unnamed-attr.rs diff --git a/src/librustc_trans/trans/context.rs b/src/librustc_trans/trans/context.rs index fd8dbe83add..75874963f5f 100644 --- a/src/librustc_trans/trans/context.rs +++ b/src/librustc_trans/trans/context.rs @@ -798,6 +798,7 @@ macro_rules! ifn { if key == $name { let f = declare::declare_cfn(ccx, $name, Type::func(&[], &$ret), ccx.tcx().mk_nil()); + llvm::SetUnnamedAddr(f, false); ccx.intrinsics().borrow_mut().insert($name, f.clone()); return Some(f); } @@ -806,6 +807,7 @@ macro_rules! ifn { if key == $name { let f = declare::declare_cfn(ccx, $name, Type::func(&[$($arg),*], &$ret), ccx.tcx().mk_nil()); + llvm::SetUnnamedAddr(f, false); ccx.intrinsics().borrow_mut().insert($name, f.clone()); return Some(f); } diff --git a/src/test/codegen/intrinsic-no-unnamed-attr.rs b/src/test/codegen/intrinsic-no-unnamed-attr.rs new file mode 100644 index 00000000000..0f239c84265 --- /dev/null +++ b/src/test/codegen/intrinsic-no-unnamed-attr.rs @@ -0,0 +1,22 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// compile-flags: -C no-prepopulate-passes + +#![feature(intrinsics)] + +extern "rust-intrinsic" { + fn sqrtf32(x: f32) -> f32; +} +// CHECK: @llvm.sqrt.f32(float) #{{[0-9]*}} + +fn main() { + unsafe { sqrtf32(0.0f32); } +}