mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #104424 - notriddle:notriddle/popover-font-size, r=GuillaumeGomez

Browse Source 
rustdoc: remove no-op CSS `.popover { font-size: 1rem }`

This rule was added in cc4f804829ae because the help popover inherited the font-size from the help button "?" icon.

It doesn't inherit this any more, because it was moved from being nested inside the link to sharing a wrapper DIV with it.
This commit is contained in:
Matthias Krüger 2022-11-16 08:36:13 +01:00 committed by GitHub
commit b9d028ae99
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/librustdoc/html/static/css/rustdoc.css
View File

@ -920,7 +920,6 @@ so that we can apply CSS-filters to change the arrow color in themes */
}
.popover {
font-size: 1rem;
position: absolute;
right: 0;
z-index: 2;
@ -928,7 +927,6 @@ so that we can apply CSS-filters to change the arrow color in themes */
margin-top: 7px;
border-radius: 3px;
border: 1px solid var(--border-color);
font-size: 1rem;
--popover-arrow-offset: 11px;
}

2
src/test/rustdoc-gui/help-page.goml
View File

@ -3,6 +3,7 @@ goto: "file://" + |DOC_PATH| + "/help.html"
size: (1000, 1000) // Try desktop size first.
wait-for: "#help"
assert-css: ("#help", {"display": "block"})
assert-css: ("#help dd", {"font-size": "16px"})
click: "#help-button > a"
assert-css: ("#help", {"display": "block"})
compare-elements-property: (".sub", "#help", ["offsetWidth"])
@ -18,6 +19,7 @@ size: (1000, 1000) // Only supported on desktop.
assert-false: "#help"
click: "#help-button > a"
assert-css: ("#help", {"display": "block"})
assert-css: ("#help dd", {"font-size": "16px"})
click: "#help-button > a"
assert-css: ("#help", {"display": "none"})
compare-elements-property-false: (".sub", "#help", ["offsetWidth"])