mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #131382 - ehuss:compiletest-reference, r=jieyouxu

Browse Source 
Add "reference" as a known compiletest header

This adds the "reference" compiletest header so that the Rust reference can add annotations to the test suite in order to link tests to individual rules in the reference.

Tooling in the reference repo will be responsible for collecting these annotations and linking to the tests.

More details are in MCP 783: https://github.com/rust-lang/compiler-team/issues/783

There is a change from the MCP in that I am not adding the JSON collection to compiletest (at least, not yet). In looking at this more closely, that actually makes things more difficult for our tooling, so I'm leaving it out for now. If in the future it looks like something we want, then I think we can add it later.

There are a few tests here which need adjusting due to the legacy header check. `@jieyouxu` indicated on Zulip that we could potentially remove the legacy header check, in which case those changes can be dropped from this PR.

r? `@jieyouxu`
This commit is contained in:
Matthias Krüger 2024-10-09 20:27:23 +02:00 committed by GitHub
commit b76667aed2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/tools/compiletest/src/command-list.rs
View File

@ -208,6 +208,7 @@
"pretty-compare-only", "pretty-compare-only",
"pretty-expanded", "pretty-expanded",
"pretty-mode", "pretty-mode",
"reference",
"regex-error-pattern", "regex-error-pattern",
"remap-src-base", "remap-src-base",
"revisions", "revisions",