mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove SpanInterner::get

Browse Source 
- It's used exactly once, so it's trivial to replace
- It doesn't match the normal convention for containers: normally
`get()` returns and option and indexing panics. Instead `get()` panicked
  and there's no indexing operation available.
This commit is contained in:
Joshua Nelson 2021-05-03 17:32:06 -04:00
parent 716394d658
commit b73ad09dfd
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
compiler/rustc_span/src/span_encoding.rs
View File

@ -102,7 +102,7 @@ pub fn data(self) -> SpanData {
// Interned format. // Interned format.
debug_assert!(self.ctxt_or_zero == 0); debug_assert!(self.ctxt_or_zero == 0);
let index = self.base_or_index; let index = self.base_or_index;
with_span_interner(|interner| *interner.get(index)) with_span_interner(|interner| interner.spans[index as usize])
} }
} }
} }
@ -117,11 +117,6 @@ fn intern(&mut self, span_data: &SpanData) -> u32 {
let (index, _) = self.spans.insert_full(*span_data); let (index, _) = self.spans.insert_full(*span_data);
index as u32 index as u32
} }
#[inline]
fn get(&self, index: u32) -> &SpanData {
&self.spans[index as usize]
}
} }
// If an interner exists, return it. Otherwise, prepare a fresh one. // If an interner exists, return it. Otherwise, prepare a fresh one.