Add FIXME to comment regarding local patterns

Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>
This commit is contained in:
Nathan Corbyn 2020-06-05 12:44:56 +01:00 committed by GitHub
parent df996e8e12
commit b4ddd91831
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -88,7 +88,7 @@ impl<'a, 'tcx> Visitor<'tcx> for FindHirNodeVisitor<'a, 'tcx> {
if let (None, Some(ty)) =
(self.found_local_pattern, self.node_ty_contains_target(local.hir_id))
{
// There's a trade-off here - we can either check that our target span
// FIXME: There's a trade-off here - we can either check that our target span
// is contained in `local.span` or not. If we choose to check containment
// we can avoid some spurious suggestions (see #72690), but we lose
// the ability to report on things like: