mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add unit test: order_of_clippy_rules

Browse Source 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
This commit is contained in:
onur-ozkan 2024-02-24 15:08:11 +03:00
parent ead18f43f8
commit b43dc065dd
1 changed files with 49 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
src/bootstrap/src/core/config/tests.rs
View File

@ -1,5 +1,6 @@
use super::{flags::Flags, ChangeIdWrapper, Config}; use super::{flags::Flags, ChangeIdWrapper, Config};
use crate::core::config::{LldMode, TomlConfig}; use crate::core::config::{LldMode, TomlConfig};
use crate::core::build_steps::check::get_clippy_rules_in_order;
use clap::CommandFactory; use clap::CommandFactory;
use serde::Deserialize; use serde::Deserialize;
@ -11,12 +12,13 @@ use std::{
}; };
fn parse(config: &str) -> Config { fn parse(config: &str) -> Config {
let config = format!("{config} \r\n build.rustc = \"/does-not-exists\" ");
Config::parse_inner( Config::parse_inner(
&[ &[
"check".to_owned(), "check".to_string(),
"--config=/does/not/exist".to_owned(), "--set=build.rustc=/does/not/exist".to_string(),
"--skip-stage0-validation".to_owned(), "--set=build.cargo=/does/not/exist".to_string(),
"--config=/does/not/exist".to_string(),
"--skip-stage0-validation".to_string(),
], ],
|&_| toml::from_str(&config).unwrap(), |&_| toml::from_str(&config).unwrap(),
) )
@ -169,7 +171,10 @@ fn override_toml_duplicate() {
Config::parse_inner( Config::parse_inner(
&[ &[
"check".to_owned(), "check".to_owned(),
"--set=build.rustc=/does/not/exist".to_string(),
"--set=build.cargo=/does/not/exist".to_string(),
"--config=/does/not/exist".to_owned(), "--config=/does/not/exist".to_owned(),
"--skip-stage0-validation".to_owned(),
"--set=change-id=1".to_owned(), "--set=change-id=1".to_owned(),
"--set=change-id=2".to_owned(), "--set=change-id=2".to_owned(),
], ],
@ -192,7 +197,15 @@ fn profile_user_dist() {
.and_then(|table: toml::Value| TomlConfig::deserialize(table)) .and_then(|table: toml::Value| TomlConfig::deserialize(table))
.unwrap() .unwrap()
} }
Config::parse_inner(&["check".to_owned()], get_toml); Config::parse_inner(
&[
"check".to_owned(),
"--set=build.rustc=/does/not/exist".to_string(),
"--set=build.cargo=/does/not/exist".to_string(),
"--skip-stage0-validation".to_string(),
],
get_toml,
);
} }
#[test] #[test]
@ -254,3 +267,34 @@ fn parse_change_id_with_unknown_field() {
let change_id_wrapper: ChangeIdWrapper = toml::from_str(config).unwrap(); let change_id_wrapper: ChangeIdWrapper = toml::from_str(config).unwrap();
assert_eq!(change_id_wrapper.inner, Some(3461)); assert_eq!(change_id_wrapper.inner, Some(3461));
} }
#[test]
fn order_of_clippy_rules() {
let args = vec![
"clippy".to_string(),
"--fix".to_string(),
"--allow-dirty".to_string(),
"--allow-staged".to_string(),
"-Aclippy:all".to_string(),
"-Wclippy::style".to_string(),
"-Aclippy::foo1".to_string(),
"-Aclippy::foo2".to_string(),
];
let config = Config::parse(&args);
let actual = match &config.cmd {
crate::Subcommand::Clippy { allow, deny, warn, forbid, .. } => {
get_clippy_rules_in_order(&args, &allow, &deny, &warn, &forbid)
}
_ => panic!("invalid subcommand"),
};
let expected = vec![
"-Aclippy:all".to_string(),
"-Wclippy::style".to_string(),
"-Aclippy::foo1".to_string(),
"-Aclippy::foo2".to_string(),
];
assert_eq!(expected, actual);
}