sync the various FromRawFd trait docs, and remove 'valid'
This commit is contained in:
parent
a473e95786
commit
b2b225e1d1
@ -85,7 +85,7 @@ pub trait FromRawFd {
|
||||
/// # Safety
|
||||
///
|
||||
/// The `fd` passed in must be an [owned file descriptor][io-safety];
|
||||
/// in particular, it must be valid and open.
|
||||
/// in particular, it must be open.
|
||||
///
|
||||
/// [io-safety]: io#io-safety
|
||||
///
|
||||
|
@ -31,17 +31,22 @@ pub trait FromRawFd {
|
||||
/// Constructs a new instance of `Self` from the given raw file
|
||||
/// descriptor and metadata.
|
||||
///
|
||||
/// This function **consumes [ownership][io-safety]** of the specified file
|
||||
/// descriptor. The returned object will take responsibility for closing
|
||||
/// it when the object goes out of scope.
|
||||
/// This function is typically used to **consume ownership** of the
|
||||
/// specified file descriptor. When used in this way, the returned object
|
||||
/// will take responsibility for closing it when the object goes out of
|
||||
/// scope.
|
||||
///
|
||||
/// [io-safety]: crate::io#io-safety
|
||||
/// However, consuming ownership is not strictly required. Use a
|
||||
/// [`From<OwnedFd>::from`] implementation for an API which strictly
|
||||
/// consumes ownership.
|
||||
///
|
||||
/// This function is also unsafe as the primitives currently returned
|
||||
/// have the contract that they are the sole owner of the file
|
||||
/// descriptor they are wrapping. Usage of this function could
|
||||
/// accidentally allow violating this contract which can cause memory
|
||||
/// unsafety in code that relies on it being true.
|
||||
/// # Safety
|
||||
///
|
||||
/// The `fd` passed in must be an [owned file descriptor][io-safety];
|
||||
/// in particular, it must be open.
|
||||
// FIXME: say something about `metadata`.
|
||||
///
|
||||
/// [io-safety]: io#io-safety
|
||||
#[unstable(feature = "sgx_platform", issue = "56975")]
|
||||
unsafe fn from_raw_fd(fd: RawFd, metadata: Self::Metadata) -> Self;
|
||||
}
|
||||
|
@ -27,17 +27,21 @@ pub trait FromRawFd {
|
||||
/// Constructs a new instance of `Self` from the given raw file
|
||||
/// descriptor.
|
||||
///
|
||||
/// This function **consumes [ownership][io-safety]** of the specified file
|
||||
/// descriptor. The returned object will take responsibility for closing
|
||||
/// it when the object goes out of scope.
|
||||
/// This function is typically used to **consume ownership** of the
|
||||
/// specified file descriptor. When used in this way, the returned object
|
||||
/// will take responsibility for closing it when the object goes out of
|
||||
/// scope.
|
||||
///
|
||||
/// [io-safety]: crate::io#io-safety
|
||||
/// However, consuming ownership is not strictly required. Use a
|
||||
/// [`From<OwnedFd>::from`] implementation for an API which strictly
|
||||
/// consumes ownership.
|
||||
///
|
||||
/// This function is also unsafe as the primitives currently returned
|
||||
/// have the contract that they are the sole owner of the file
|
||||
/// descriptor they are wrapping. Usage of this function could
|
||||
/// accidentally allow violating this contract which can cause memory
|
||||
/// unsafety in code that relies on it being true.
|
||||
/// # Safety
|
||||
///
|
||||
/// The `fd` passed in must be an [owned file descriptor][io-safety];
|
||||
/// in particular, it must be open.
|
||||
///
|
||||
/// [io-safety]: io#io-safety
|
||||
unsafe fn from_raw_fd(fd: RawFd) -> Self;
|
||||
}
|
||||
|
||||
|
@ -62,7 +62,7 @@ pub trait FromRawHandle {
|
||||
/// # Safety
|
||||
///
|
||||
/// The `handle` passed in must:
|
||||
/// - be a valid an open handle,
|
||||
/// - be an [owned handle][io-safety]; in particular, it must be open.
|
||||
/// - be a handle for a resource that may be freed via [`CloseHandle`]
|
||||
/// (as opposed to `RegCloseKey` or other close functions).
|
||||
///
|
||||
@ -71,6 +71,7 @@ pub trait FromRawHandle {
|
||||
///
|
||||
/// [`CloseHandle`]: https://docs.microsoft.com/en-us/windows/win32/api/handleapi/nf-handleapi-closehandle
|
||||
/// [here]: https://devblogs.microsoft.com/oldnewthing/20040302-00/?p=40443
|
||||
/// [io-safety]: io#io-safety
|
||||
#[stable(feature = "from_raw_os", since = "1.1.0")]
|
||||
unsafe fn from_raw_handle(handle: RawHandle) -> Self;
|
||||
}
|
||||
@ -207,10 +208,11 @@ pub trait FromRawSocket {
|
||||
/// # Safety
|
||||
///
|
||||
/// The `socket` passed in must:
|
||||
/// - be a valid an open socket,
|
||||
/// - be an [owned socket][io-safety]; in particular, it must be open.
|
||||
/// - be a socket that may be freed via [`closesocket`].
|
||||
///
|
||||
/// [`closesocket`]: https://docs.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-closesocket
|
||||
/// [io-safety]: io#io-safety
|
||||
#[stable(feature = "from_raw_os", since = "1.1.0")]
|
||||
unsafe fn from_raw_socket(sock: RawSocket) -> Self;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user