mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use trimmed instead of line for performance

Browse Source
This commit is contained in:
est31 2023-03-04 21:41:24 +01:00
parent 3a20d52694
commit b2aeb07137
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/tools/tidy/src/style.rs
View File

@ -431,14 +431,14 @@ fn skip(path: &Path) -> bool {
} }
if filename.ends_with(".ftl") { if filename.ends_with(".ftl") {
let line_backticks = line.chars().filter(|ch| *ch == '`').count(); let line_backticks = trimmed.chars().filter(|ch| *ch == '`').count();
if line_backticks % 2 == 1 { if line_backticks % 2 == 1 {
suppressible_tidy_err!(err, skip_odd_backticks, "odd number of backticks"); suppressible_tidy_err!(err, skip_odd_backticks, "odd number of backticks");
} }
} else if line.contains("//") { } else if trimmed.contains("//") {
let (start_line, mut backtick_count) = comment_block.unwrap_or((i + 1, 0)); let (start_line, mut backtick_count) = comment_block.unwrap_or((i + 1, 0));
let line_backticks = line.chars().filter(|ch| *ch == '`').count(); let line_backticks = trimmed.chars().filter(|ch| *ch == '`').count();
let comment_text = line.split("//").nth(1).unwrap(); let comment_text = trimmed.split("//").nth(1).unwrap();
// This check ensures that we don't lint for code that has `//` in a string literal // This check ensures that we don't lint for code that has `//` in a string literal
if line_backticks % 2 == 1 { if line_backticks % 2 == 1 {
backtick_count += comment_text.chars().filter(|ch| *ch == '`').count(); backtick_count += comment_text.chars().filter(|ch| *ch == '`').count();