remove non_durable_rename in rustc_interface::util
This commit is contained in:
parent
5aac75a8da
commit
b28b7c90cb
@ -655,24 +655,6 @@ pub fn build_output_filenames(
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(not(target_os = "linux"))]
|
||||
pub fn non_durable_rename(src: &Path, dst: &Path) -> std::io::Result<()> {
|
||||
std::fs::rename(src, dst)
|
||||
}
|
||||
|
||||
/// This function attempts to bypass the auto_da_alloc heuristic implemented by some filesystems
|
||||
/// such as btrfs and ext4. When renaming over a file that already exists then they will "helpfully"
|
||||
/// write back the source file before committing the rename in case a developer forgot some of
|
||||
/// the fsyncs in the open/write/fsync(file)/rename/fsync(dir) dance for atomic file updates.
|
||||
///
|
||||
/// To avoid triggering this heuristic we delete the destination first, if it exists.
|
||||
/// The cost of an extra syscall is much lower than getting descheduled for the sync IO.
|
||||
#[cfg(target_os = "linux")]
|
||||
pub fn non_durable_rename(src: &Path, dst: &Path) -> std::io::Result<()> {
|
||||
let _ = std::fs::remove_file(dst);
|
||||
std::fs::rename(src, dst)
|
||||
}
|
||||
|
||||
/// Returns a version string such as "1.46.0 (04488afe3 2020-08-24)"
|
||||
pub fn version_str() -> Option<&'static str> {
|
||||
option_env!("CFG_VERSION")
|
||||
|
Loading…
Reference in New Issue
Block a user