mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Handle rustc_on_unimplemented in duplicated_attributes

Browse Source
This commit is contained in:
Nilstrieb 2024-05-01 17:50:28 +02:00
parent 852a64f875
commit b10be16702
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clippy_lints/src/attrs/duplicated_attributes.rs
View File

@ -36,9 +36,10 @@ fn check_duplicated_attr(
} }
let Some(ident) = attr.ident() else { return }; let Some(ident) = attr.ident() else { return };
let name = ident.name; let name = ident.name;
if name == sym::doc || name == sym::cfg_attr { if name == sym::doc || name == sym::cfg_attr || name == sym::rustc_on_unimplemented {
// FIXME: Would be nice to handle `cfg_attr` as well. Only problem is to check that cfg // FIXME: Would be nice to handle `cfg_attr` as well. Only problem is to check that cfg
// conditions are the same. // conditions are the same.
// `#[rustc_on_unimplemented]` contains duplicated subattributes, that's expected.
return; return;
} }
if let Some(direct_parent) = parent.last() if let Some(direct_parent) = parent.last()

6
tests/ui/duplicated_attributes.rs
View File

@ -1,5 +1,5 @@
//@aux-build:proc_macro_attr.rs //@aux-build:proc_macro_attr.rs
#![feature(rustc_attrs)]
#![warn(clippy::duplicated_attributes)] #![warn(clippy::duplicated_attributes)]
#![cfg(any(unix, windows))] #![cfg(any(unix, windows))]
#![allow(dead_code)] #![allow(dead_code)]
@ -20,6 +20,10 @@ fn foo() {}
#[cfg(unix)] // cfgs are not handled #[cfg(unix)] // cfgs are not handled
fn bar() {} fn bar() {}
// No warning:
#[rustc_on_unimplemented(on(_Self = "&str", label = "`a"), on(_Self = "alloc::string::String", label = "a"))]
trait Abc {}
#[proc_macro_attr::duplicated_attr()] // Should not warn! #[proc_macro_attr::duplicated_attr()] // Should not warn!
fn babar() {} fn babar() {}