mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update/remove some old comments

Browse Source
This commit is contained in:
Ralf Jung 2022-05-10 13:28:22 +02:00
parent 600d960261
commit aef8a9306d
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
compiler/rustc_const_eval/src/interpret/place.rs
View File

@ -736,20 +736,16 @@ where
dest: &MPlaceTy<'tcx, M::PointerTag>, dest: &MPlaceTy<'tcx, M::PointerTag>,
) -> InterpResult<'tcx> { ) -> InterpResult<'tcx> {
// Note that it is really important that the type here is the right one, and matches the // Note that it is really important that the type here is the right one, and matches the
// type things are read at. In case `src_val` is a `ScalarPair`, we don't do any magic here // type things are read at. In case `value` is a `ScalarPair`, we don't do any magic here
// to handle padding properly, which is only correct if we never look at this data with the // to handle padding properly, which is only correct if we never look at this data with the
// wrong type. // wrong type.
// Invalid places are a thing: the return place of a diverging function
let tcx = *self.tcx; let tcx = *self.tcx;
let Some(mut alloc) = self.get_place_alloc_mut(dest)? else { let Some(mut alloc) = self.get_place_alloc_mut(dest)? else {
// zero-sized access // zero-sized access
return Ok(()); return Ok(());
}; };
// FIXME: We should check that there are dest.layout.size many bytes available in
// memory. The code below is not sufficient, with enough padding it might not
// cover all the bytes!
match value { match value {
Immediate::Scalar(scalar) => { Immediate::Scalar(scalar) => {
let Abi::Scalar(s) = dest.layout.abi else { span_bug!( let Abi::Scalar(s) = dest.layout.abi else { span_bug!(