diff --git a/clippy_lints/src/lib.rs b/clippy_lints/src/lib.rs index 2e481151d29..8ea4aa35140 100644 --- a/clippy_lints/src/lib.rs +++ b/clippy_lints/src/lib.rs @@ -542,7 +542,7 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry) { serde_api::SERDE_API_MISUSE, should_assert_eq::SHOULD_ASSERT_EQ, strings::STRING_LIT_AS_BYTES, - suggest_print::SUGGEST_PRINT, + suggest_print::EXPLICIT_WRITE, swap::ALMOST_SWAPPED, swap::MANUAL_SWAP, temporary_assignment::TEMPORARY_ASSIGNMENT, diff --git a/clippy_lints/src/suggest_print.rs b/clippy_lints/src/suggest_print.rs index eb1266af7b7..8349328a18a 100644 --- a/clippy_lints/src/suggest_print.rs +++ b/clippy_lints/src/suggest_print.rs @@ -16,7 +16,7 @@ use utils::opt_def_id; /// writeln!(&mut io::stderr(), "foo: {:?}", bar).unwrap(); /// ``` declare_lint! { - pub SUGGEST_PRINT, + pub EXPLICIT_WRITE, Warn, "using `write!()` family of functions instead of `print!()` family of \ functions, when using the latter would work" @@ -27,7 +27,7 @@ pub struct Pass; impl LintPass for Pass { fn get_lints(&self) -> LintArray { - lint_array!(SUGGEST_PRINT) + lint_array!(EXPLICIT_WRITE) } } @@ -74,7 +74,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass { if let Some(macro_name) = calling_macro { span_lint( cx, - SUGGEST_PRINT, + EXPLICIT_WRITE, expr.span, &format!( "use of `{}!({}(), ...).unwrap()`. Consider using `{}{}!` instead", @@ -87,7 +87,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass { } else { span_lint( cx, - SUGGEST_PRINT, + EXPLICIT_WRITE, expr.span, &format!( "use of `{}().write_fmt(...).unwrap()`. Consider using `{}print!` instead", diff --git a/tests/ui/suggest_print.rs b/tests/ui/suggest_print.rs index 0466d6c0b60..71992123ceb 100644 --- a/tests/ui/suggest_print.rs +++ b/tests/ui/suggest_print.rs @@ -1,4 +1,4 @@ -#![warn(suggest_print)] +#![warn(explicit_write)] fn stdout() -> String { diff --git a/tests/ui/suggest_print.stderr b/tests/ui/suggest_print.stderr index bae9f6f2679..12e656b5540 100644 --- a/tests/ui/suggest_print.stderr +++ b/tests/ui/suggest_print.stderr @@ -4,7 +4,7 @@ error: use of `write!(stdout(), ...).unwrap()`. Consider using `print!` instead 16 | write!(std::io::stdout(), "test").unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | - = note: `-D suggest-print` implied by `-D warnings` + = note: `-D explicit-write` implied by `-D warnings` error: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead --> $DIR/suggest_print.rs:17:9