mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make LocalWaker::will_wake consistent with Waker::will_wake

Browse Source
This commit is contained in:
Ralf Jung 2024-08-09 18:05:57 +02:00
parent 899eb03926
commit ae09340350
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
library/core/src/task/wake.rs
View File

@ -502,6 +502,8 @@ pub fn wake_by_ref(&self) {
#[must_use] #[must_use]
#[stable(feature = "futures_api", since = "1.36.0")] #[stable(feature = "futures_api", since = "1.36.0")]
pub fn will_wake(&self, other: &Waker) -> bool { pub fn will_wake(&self, other: &Waker) -> bool {
// We optimize this by comparing vtable addresses instead of vtable contents.
// This is permitted since the function is documented as best-effort.
let RawWaker { data: a_data, vtable: a_vtable } = self.waker; let RawWaker { data: a_data, vtable: a_vtable } = self.waker;
let RawWaker { data: b_data, vtable: b_vtable } = other.waker; let RawWaker { data: b_data, vtable: b_vtable } = other.waker;
a_data == b_data && ptr::eq(a_vtable, b_vtable) a_data == b_data && ptr::eq(a_vtable, b_vtable)
@ -761,7 +763,11 @@ pub fn wake_by_ref(&self) {
#[must_use] #[must_use]
#[unstable(feature = "local_waker", issue = "118959")] #[unstable(feature = "local_waker", issue = "118959")]
pub fn will_wake(&self, other: &LocalWaker) -> bool { pub fn will_wake(&self, other: &LocalWaker) -> bool {
self.waker == other.waker // We optimize this by comparing vtable addresses instead of vtable contents.
// This is permitted since the function is documented as best-effort.
let RawWaker { data: a_data, vtable: a_vtable } = self.waker;
let RawWaker { data: b_data, vtable: b_vtable } = other.waker;
a_data == b_data && ptr::eq(a_vtable, b_vtable)
} }
/// Creates a new `LocalWaker` from [`RawWaker`]. /// Creates a new `LocalWaker` from [`RawWaker`].