Remove redundant success expressions from steps

This commit is contained in:
Jakub Beránek 2024-04-27 12:02:05 +02:00
parent 24bf3594a5
commit adbc84cfac
No known key found for this signature in database
GPG Key ID: 909CD0D26483516B

View File

@ -116,7 +116,7 @@ jobs:
run: echo "[CI_PR_NUMBER=$num]"
env:
num: ${{ github.event.number }}
if: success() && github.event_name == 'pull_request'
if: github.event_name == 'pull_request'
- name: add extra environment variables
run: src/ci/scripts/setup-environment.sh
@ -219,7 +219,7 @@ jobs:
# adding the condition is helpful as this way CI will not silently skip
# deploying artifacts from a dist builder if the variables are misconfigured,
# erroring about invalid credentials instead.
if: success() && (github.event_name == 'push' || env.DEPLOY == '1' || env.DEPLOY_ALT == '1')
if: github.event_name == 'push' || env.DEPLOY == '1' || env.DEPLOY_ALT == '1'
# This job isused to tell bors the final status of the build, as there is no practical way to detect
# when a workflow is successful listening to webhooks only in our current bors implementation (homu).