Add regression test for #92308

This amends off of an existing test introduced in #81769, if you think I
should make a separate test I will.
This commit is contained in:
ThePuzzlemaker 2021-12-28 19:39:33 -06:00
parent eddf80698f
commit ab7c446492
No known key found for this signature in database
GPG Key ID: 968CD9D71C9FBB6C
2 changed files with 42 additions and 2 deletions

View File

@ -1,3 +1,16 @@
// > Suggest `return`ing tail expressions that match return type
// >
// > Some newcomers are confused by the behavior of tail expressions,
// > interpreting that "leaving out the `;` makes it the return value".
// > To help them go in the right direction, suggest using `return` instead
// > when applicable.
// (original commit description for this test)
//
// This test was amended to also serve as a regression test for #92308, where
// this suggestion would not trigger with async functions.
//
// edition:2018
fn main() {
let _ = foo(true);
}
@ -5,6 +18,15 @@ fn main() {
fn foo(x: bool) -> Result<f64, i32> {
if x {
Err(42) //~ ERROR mismatched types
//| HELP you might have meant to return this value
}
Ok(42.0)
}
async fn bar(x: bool) -> Result<f64, i32> {
if x {
Err(42) //~ ERROR mismatched types
//| HELP you might have meant to return this value
}
Ok(42.0)
}

View File

@ -1,9 +1,10 @@
error[E0308]: mismatched types
--> $DIR/tail-expr-as-potential-return.rs:7:9
--> $DIR/tail-expr-as-potential-return.rs:28:9
|
LL | / if x {
LL | | Err(42)
| | ^^^^^^^ expected `()`, found enum `Result`
LL | | //| HELP you might have meant to return this value
LL | | }
| |_____- expected this to be `()`
|
@ -14,6 +15,23 @@ help: you might have meant to return this value
LL | return Err(42);
| ++++++ +
error: aborting due to previous error
error[E0308]: mismatched types
--> $DIR/tail-expr-as-potential-return.rs:20:9
|
LL | / if x {
LL | | Err(42)
| | ^^^^^^^ expected `()`, found enum `Result`
LL | | //| HELP you might have meant to return this value
LL | | }
| |_____- expected this to be `()`
|
= note: expected unit type `()`
found enum `Result<_, {integer}>`
help: you might have meant to return this value
|
LL | return Err(42);
| ++++++ +
error: aborting due to 2 previous errors
For more information about this error, try `rustc --explain E0308`.