move hygiene to hir_expand

crates/ra_hir/src/expr/lower.rs

@@ -1,7 +1,10 @@
 //! FIXME: write short doc here
 
-use hir_def::{hygiene::Hygiene, path::GenericArgs, type_ref::TypeRef};
+use hir_def::{path::GenericArgs, type_ref::TypeRef};
-use hir_expand::name::{self, AsName, Name};
+use hir_expand::{
+    hygiene::Hygiene,
+    name::{self, AsName, Name},
+};
 use ra_arena::Arena;
 use ra_syntax::{
     ast::{

crates/ra_hir/src/impl_block.rs

@@ -3,7 +3,8 @@
 use rustc_hash::FxHashMap;
 use std::sync::Arc;
 
-use hir_def::{attr::Attr, hygiene::Hygiene, type_ref::TypeRef};
+use hir_def::{attr::Attr, type_ref::TypeRef};
+use hir_expand::hygiene::Hygiene;
 use ra_arena::{impl_arena_id, map::ArenaMap, Arena, RawId};
 use ra_cfg::CfgOptions;
 use ra_syntax::{

crates/ra_hir_def/src/attr.rs

@@ -2,6 +2,7 @@
 
 use std::sync::Arc;
 
+use hir_expand::hygiene::Hygiene;
 use mbe::ast_to_token_tree;
 use ra_cfg::CfgOptions;
 use ra_syntax::{
@@ -10,7 +11,7 @@
 };
 use tt::Subtree;
 
-use crate::{hygiene::Hygiene, path::Path};
+use crate::path::Path;
 
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub struct Attr {

crates/ra_hir_def/src/lib.rs

@@ -11,7 +11,6 @@
 pub mod attr;
 pub mod path;
 pub mod type_ref;
-pub mod hygiene;
 
 // FIXME: this should be private
 pub mod nameres;

crates/ra_hir_def/src/nameres/raw.rs

@@ -6,6 +6,7 @@
     ast_id_map::AstIdMap,
     db::AstDatabase,
     either::Either,
+    hygiene::Hygiene,
     name::{AsName, Name},
 };
 use ra_arena::{impl_arena_id, map::ArenaMap, Arena, RawId};
@@ -14,10 +15,7 @@
     AstNode, AstPtr, SourceFile,
 };
 
-use crate::{
+use crate::{attr::Attr, db::DefDatabase2, path::Path, FileAstId, HirFileId, ModuleSource, Source};
-    attr::Attr, db::DefDatabase2, hygiene::Hygiene, path::Path, FileAstId, HirFileId, ModuleSource,
-    Source,
-};
 
 /// `RawItems` is a set of top-level items in a file (except for impls).
 ///

crates/ra_hir_def/src/path.rs

@@ -4,6 +4,7 @@
 
 use hir_expand::{
     either::Either,
+    hygiene::Hygiene,
     name::{self, AsName, Name},
 };
 use ra_db::CrateId;
@@ -12,7 +13,7 @@
     AstNode,
 };
 
-use crate::{hygiene::Hygiene, type_ref::TypeRef, Source};
+use crate::{type_ref::TypeRef, Source};
 
 #[derive(Debug, Clone, PartialEq, Eq, Hash)]
 pub struct Path {

crates/ra_hir_expand/src/hygiene.rs

@@ -2,16 +2,15 @@
 //!
 //! Specifically, `ast` + `Hygiene` allows you to create a `Name`. Note that, at
 //! this moment, this is horribly incomplete and handles only `$crate`.
-// Should this be moved to `hir_expand`? Seems like it.
+use ra_db::CrateId;
+use ra_syntax::ast;
 
-use hir_expand::{
+use crate::{
     db::AstDatabase,
     either::Either,
     name::{AsName, Name},
-    HirFileId,
+    HirFileId, HirFileIdRepr,
 };
-use ra_db::CrateId;
-use ra_syntax::ast;
 
 #[derive(Debug)]
 pub struct Hygiene {
@@ -21,15 +20,22 @@ pub struct Hygiene {
 
 impl Hygiene {
     pub fn new(db: &impl AstDatabase, file_id: HirFileId) -> Hygiene {
-        Hygiene { def_crate: file_id.macro_crate(db) }
+        let def_crate = match file_id.0 {
+            HirFileIdRepr::FileId(_) => None,
+            HirFileIdRepr::MacroFile(macro_file) => {
+                let loc = db.lookup_intern_macro(macro_file.macro_call_id);
+                Some(loc.def.krate)
+            }
+        };
+        Hygiene { def_crate }
     }
 
-    pub(crate) fn new_unhygienic() -> Hygiene {
+    pub fn new_unhygienic() -> Hygiene {
         Hygiene { def_crate: None }
     }
 
     // FIXME: this should just return name
-    pub(crate) fn name_ref_to_name(&self, name_ref: ast::NameRef) -> Either<Name, CrateId> {
+    pub fn name_ref_to_name(&self, name_ref: ast::NameRef) -> Either<Name, CrateId> {
         if let Some(def_crate) = self.def_crate {
             if name_ref.text() == "$crate" {
                 return Either::B(def_crate);

crates/ra_hir_expand/src/lib.rs

@@ -8,6 +8,7 @@
 pub mod ast_id_map;
 pub mod either;
 pub mod name;
+pub mod hygiene;
 
 use std::hash::{Hash, Hasher};
 
@@ -61,17 +62,6 @@ pub fn original_file(self, db: &dyn db::AstDatabase) -> FileId {
             }
         }
     }
-
-    /// Get the crate which the macro lives in, if it is a macro file.
-    pub fn macro_crate(self, db: &dyn db::AstDatabase) -> Option<CrateId> {
-        match self.0 {
-            HirFileIdRepr::FileId(_) => None,
-            HirFileIdRepr::MacroFile(macro_file) => {
-                let loc = db.lookup_intern_macro(macro_file.macro_call_id);
-                Some(loc.def.krate)
-            }
-        }
-    }
 }
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]