mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Stop linting manual_bits in any macro invoke

Browse Source
This commit is contained in:
GnomedDev 2024-10-18 21:41:05 +01:00
parent 6a795887c4
commit a739cc3abe
No known key found for this signature in database
3 changed files with 24 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clippy_lints/src/manual_bits.rs
View File

@ -7,8 +7,7 @@
use rustc_data_structures::packed::Pu128; use rustc_data_structures::packed::Pu128;
use rustc_errors::Applicability; use rustc_errors::Applicability;
use rustc_hir::{BinOpKind, Expr, ExprKind, GenericArg, QPath}; use rustc_hir::{BinOpKind, Expr, ExprKind, GenericArg, QPath};
use rustc_lint::{LateContext, LateLintPass, LintContext}; use rustc_lint::{LateContext, LateLintPass};
use rustc_middle::lint::in_external_macro;
use rustc_middle::ty::{self, Ty}; use rustc_middle::ty::{self, Ty};
use rustc_session::impl_lint_pass; use rustc_session::impl_lint_pass;
use rustc_span::sym; use rustc_span::sym;
@ -53,7 +52,7 @@ impl<'tcx> LateLintPass<'tcx> for ManualBits {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) { fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
if let ExprKind::Binary(bin_op, left_expr, right_expr) = expr.kind if let ExprKind::Binary(bin_op, left_expr, right_expr) = expr.kind
&& let BinOpKind::Mul = &bin_op.node && let BinOpKind::Mul = &bin_op.node
&& !in_external_macro(cx.sess(), expr.span) && !expr.span.from_expansion()
&& self.msrv.meets(msrvs::MANUAL_BITS) && self.msrv.meets(msrvs::MANUAL_BITS)
&& let ctxt = expr.span.ctxt() && let ctxt = expr.span.ctxt()
&& left_expr.span.ctxt() == ctxt && left_expr.span.ctxt() == ctxt

11
tests/ui/manual_bits.fixed
View File

@ -56,3 +56,14 @@ fn main() {
let _ = (u128::BITS as usize).pow(5); let _ = (u128::BITS as usize).pow(5);
let _ = &(u128::BITS as usize); let _ = &(u128::BITS as usize);
} }
fn should_not_lint() {
macro_rules! bits_via_macro {
($T: ty) => {
size_of::<$T>() * 8;
};
}
bits_via_macro!(u8);
bits_via_macro!(String);
}

11
tests/ui/manual_bits.rs
View File

@ -56,3 +56,14 @@ fn main() {
let _ = (size_of::<u128>() * 8).pow(5); let _ = (size_of::<u128>() * 8).pow(5);
let _ = &(size_of::<u128>() * 8); let _ = &(size_of::<u128>() * 8);
} }
fn should_not_lint() {
macro_rules! bits_via_macro {
($T: ty) => {
size_of::<$T>() * 8;
};
}
bits_via_macro!(u8);
bits_via_macro!(String);
}