mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libcore: remove default to_str implementations for pointer types

Browse Source 
These couldn't be overridden and so ended up being quite restrictive. This has
the side effect of changing the stringification of ~vecs, but nothing in
relied on this. Closes #4869.
This commit is contained in:
Peter Williams 2013-02-23 17:41:44 -05:00
parent 82062a6348
commit a712d828f9
1 changed files with 5 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/libcore/to_str.rs
View File

@ -1,4 +1,4 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
@ -94,15 +94,6 @@ impl<A:ToStr> ToStr for ~[A] {
}
}
impl<A:ToStr> ToStr for @A {
#[inline(always)]
pure fn to_str(&self) -> ~str { ~"@" + (**self).to_str() }
}
impl<A:ToStr> ToStr for ~A {
#[inline(always)]
pure fn to_str(&self) -> ~str { ~"~" + (**self).to_str() }
}
#[cfg(test)]
#[allow(non_implicitly_copyable_typarams)]
mod tests {
@ -127,19 +118,12 @@ mod tests {
}
#[test]
#[ignore]
fn test_vectors() {
let x: ~[int] = ~[];
assert x.to_str() == ~"~[]";
assert (~[1]).to_str() == ~"~[1]";
assert (~[1, 2, 3]).to_str() == ~"~[1, 2, 3]";
assert x.to_str() == ~"[]";
assert (~[1]).to_str() == ~"[1]";
assert (~[1, 2, 3]).to_str() == ~"[1, 2, 3]";
assert (~[~[], ~[1], ~[1, 1]]).to_str() ==
~"~[~[], ~[1], ~[1, 1]]";
}
#[test]
fn test_pointer_types() {
assert (@1).to_str() == ~"@1";
assert (~(true, false)).to_str() == ~"~(true, false)";
~"[[], [1], [1, 1]]";
}
}