Rollup merge of #113578 - compiler-errors:uncallable-sig, r=b-naber

Don't say that a type is uncallable if its fn signature has errors in it

This is fallout from #106309, where we don't consider param-env candidates that reference errors because they unify with everything. This means, however, that we don't consider an APIT like `impl Fn(MissingType)` isn't considered to implement `Fn`, for example.

We can double-check that with a weaker heuristic [`extract_callable_info`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_typeck/fn_ctxt/struct.FnCtxt.html#method.extract_callable_info), and suppress the knock-down error using that.

Fixes #113566
This commit is contained in:
Matthias Krüger 2023-07-25 23:34:07 +02:00 committed by GitHub
commit a6bf68d8d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 25 additions and 0 deletions

View File

@ -581,6 +581,14 @@ fn report_invalid_callee(
callee_ty: Ty<'tcx>,
arg_exprs: &'tcx [hir::Expr<'tcx>],
) -> ErrorGuaranteed {
// Callee probe fails when APIT references errors, so suppress those
// errors here.
if let Some((_, _, args)) = self.extract_callable_info(callee_ty)
&& let Err(err) = args.error_reported()
{
return err;
}
let mut unit_variant = None;
if let hir::ExprKind::Path(qpath) = &callee_expr.kind
&& let Res::Def(def::DefKind::Ctor(kind, CtorKind::Const), _)

View File

@ -0,0 +1,8 @@
type Foo = Bar;
//~^ ERROR cannot find type `Bar` in this scope
fn check(f: impl FnOnce(Foo), val: Foo) {
f(val);
}
fn main() {}

View File

@ -0,0 +1,9 @@
error[E0412]: cannot find type `Bar` in this scope
--> $DIR/apit-with-error-type-in-sig.rs:1:12
|
LL | type Foo = Bar;
| ^^^ not found in this scope
error: aborting due to previous error
For more information about this error, try `rustc --explain E0412`.