From bcbc9e5346941011f36f71f66c808675b263a589 Mon Sep 17 00:00:00 2001
From: Barosl Lee <vcs@barosl.com>
Date: Mon, 29 Feb 2016 15:04:22 +0900
Subject: [PATCH] Describe more platform-specific behaviors of
`std::fs::rename`
Fixes #31301.
---
src/libstd/fs.rs | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/libstd/fs.rs b/src/libstd/fs.rs
index c4d6cb33365..6777dfdabb7 100644
--- a/src/libstd/fs.rs
+++ b/src/libstd/fs.rs
@@ -968,7 +968,8 @@ pub fn symlink_metadata<P: AsRef<Path>>(path: P) -> io::Result<Metadata> {
fs_imp::lstat(path.as_ref()).map(Metadata)
}
-/// Rename a file or directory to a new name.
+/// Rename a file or directory to a new name, replacing the original file if
+/// `to` already exists.
///
/// This will not work if the new name is on a different mount point.
///
@@ -976,6 +977,12 @@ pub fn symlink_metadata<P: AsRef<Path>>(path: P) -> io::Result<Metadata> {
///
/// This function currently corresponds to the `rename` function on Unix
/// and the `MoveFileEx` function with the `MOVEFILE_REPLACE_EXISTING` flag on Windows.
+///
+/// Because of this, the behavior when both `from` and `to` exist differs. On
+/// Unix, if `from` is a directory, `to` must also be an (empty) directory. If
+/// `from` is not a directory, `to` must also be not a directory. In contrast,
+/// on Windows, `from` can be anything, but `to` must *not* be a directory.
+///
/// Note that, this [may change in the future][changes].
/// [changes]: ../io/index.html#platform-specific-behavior
///