Rollup merge of #99628 - vincenzopalazzo:macros/is_number_doc, r=joshtriplett
add more docs regarding ideographic numbers This was discussed in the last lib meeting and I try to avoid forgetting to open a PR because I think having some docs can help people. However, I think we need to discuss a little bit if this is enough or if we need to add more clarification? Maybe an example? Inspiration Source: https://github.com/rust-lang/rust/issues/84056#issuecomment-1184725924 Including suggestion https://github.com/rust-lang/rust/pull/99626#issuecomment-1192983043 my bad command git close the PR
This commit is contained in:
commit
a479cab09a
@ -892,7 +892,16 @@ pub(crate) fn is_grapheme_extended(self) -> bool {
|
||||
///
|
||||
/// The general categories for numbers (`Nd` for decimal digits, `Nl` for letter-like numeric
|
||||
/// characters, and `No` for other numeric characters) are specified in the [Unicode Character
|
||||
/// Database][ucd] [`UnicodeData.txt`].
|
||||
/// Database][ucd] [`UnicodeData.txt`]. Note that this means ideographic numbers like '三'
|
||||
/// are considered alphabetic, not numeric. Please consider to use `is_ascii_digit` or `is_digit`.
|
||||
///
|
||||
/// This method doesn't cover everything that could be considered a number, e.g. ideographic numbers like '三'.
|
||||
/// If you want everything including characters with overlapping purposes then you might want to use
|
||||
/// a unicode or language-processing library that exposes the appropriate character properties instead
|
||||
/// of looking at the unicode categories.
|
||||
///
|
||||
/// If you want to parse ASCII decimal digits (0-9) or ASCII base-N, use
|
||||
/// `is_ascii_digit` or `is_digit` instead.
|
||||
///
|
||||
/// [Unicode Standard]: https://www.unicode.org/versions/latest/
|
||||
/// [ucd]: https://www.unicode.org/reports/tr44/
|
||||
@ -911,6 +920,7 @@ pub(crate) fn is_grapheme_extended(self) -> bool {
|
||||
/// assert!(!'K'.is_numeric());
|
||||
/// assert!(!'و'.is_numeric());
|
||||
/// assert!(!'藏'.is_numeric());
|
||||
/// assert!(!'三'.is_numeric());
|
||||
/// ```
|
||||
#[must_use]
|
||||
#[stable(feature = "rust1", since = "1.0.0")]
|
||||
|
Loading…
Reference in New Issue
Block a user