mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

from_str_radix_10 should be done

Browse Source
This commit is contained in:
boolean_coercion 2021-02-11 12:30:23 +02:00
parent 64729390a1
commit a389c02461
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
clippy_lints/src/from_str_radix_10.rs
View File

@ -52,18 +52,20 @@ impl LateLintPass<'tcx> for FromStrRadix10 {
// function `from_str_radix`
if pathseg.ident.name.as_str() == "from_str_radix";
// check if the second argument resolves to a constant `10`
// check if the second argument is a primitive `10`
if arguments.len() == 2;
if is_constant_10(&arguments[1]);
if let ExprKind::Lit(lit) = &arguments[1].kind;
if let rustc_ast::ast::LitKind::Int(10, _) = lit.node;
then {
let orig_string = crate::utils::snippet(cx, arguments[0].span, "string");
span_lint_and_sugg(
cx,
FROM_STR_RADIX_10,
exp.span,
"This call to `from_str_radix` can be shortened to a call to str::parse",
"try",
format!("TODO"),
format!("({}).parse()", orig_string),
Applicability::MachineApplicable
);
}
@ -77,9 +79,4 @@ fn is_primitive_integer_ty(ty: PrimTy) -> bool {
PrimTy::Uint(_) => true,
_ => false
}
}
fn is_constant_10<'tcx>(expr: &Expr<'tcx>) -> bool {
// TODO
true
}